github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6168] [CLOSED] make the sync-server test suite run on compiled files #88550

New Issue
Closed
opened 2026-05-22 12:01:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 12:01:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6168
Author: @matt-fidd
Created: 11/17/2025
Status: ❌ Closed

Base: master ← Head: sync-server-tests

📝 Commits (4)

📊 Changes

6 files changed (+26 additions, -4 deletions)

View changed files

📝 eslint.config.mjs (+15 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/sync-server/package.json (+1 -1)
📝 packages/sync-server/vitest.config.ts (+2 -1)
📝 packages/sync-server/vitest.globalSetup.js (+2 -2)
➕ upcoming-release-notes/6168.md (+6 -0)

📄 Description

This will fix the issue seen here where the extension has to be .js to work at runtime, but vitest couldn't find it (because it didn't exist!) https://github.com/actualbudget/actual/pull/6142#discussion_r2531042086

It makes sense for the tests to run on the code that would actually run anyway I suppose.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6168 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 11/17/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `sync-server-tests` --- ### 📝 Commits (4) - [`e4aac49`](https://github.com/actualbudget/actual/commit/e4aac499a1a255ea4942ccf7629d75d7166fb83e) run sync server tests on compiled js - [`000f5df`](https://github.com/actualbudget/actual/commit/000f5dfc8dcc2567f91e3bf8a566bab70be80b9e) note - [`0199dd9`](https://github.com/actualbudget/actual/commit/0199dd9247b87f915e09f5ab1a0ace58d433c857) fix lint - [`b4f5b57`](https://github.com/actualbudget/actual/commit/b4f5b571e6fdd9fe3fb87520a37f0871d2f0ac19) Update VRT screenshots ### 📊 Changes **6 files changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `eslint.config.mjs` (+15 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/sync-server/package.json` (+1 -1) 📝 `packages/sync-server/vitest.config.ts` (+2 -1) 📝 `packages/sync-server/vitest.globalSetup.js` (+2 -2) ➕ `upcoming-release-notes/6168.md` (+6 -0) </details> ### 📄 Description This will fix the issue seen here where the extension has to be .js to work at runtime, but vitest couldn't find it (because it didn't exist!) https://github.com/actualbudget/actual/pull/6142#discussion_r2531042086 It makes sense for the tests to run on the code that would actually run anyway I suppose. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 12:01:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#88550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?