github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5961] [MERGED] ♻️ (typescript) Convert BudgetCategories to TypeScript #88420

New Issue
Closed
opened 2026-05-22 11:44:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-22 11:44:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5961
Author: @MatissJanis
Created: 10/18/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/ts-budget-categories

📝 Commits (10+)

  • e057301 move to tsx
  • 3cf50d7 refactor: update types in BudgetCategories and sort components
  • 5d39f78 Add release notes
  • 8978652 refactor: enhance type definitions in budget components
  • 7a31b70 Merge branch 'master' into matiss/ts-budget-categories
  • 149445d refactor: improve type definitions in budget components
  • 88c5e15 Merge branch 'matiss/ts-budget-categories' of github.com:actualbudget/actual into matiss/ts-budget-categories
  • 744df7e Fix: Allow reordering categories to null target
  • f69b88c Merge branch 'master' into matiss/ts-budget-categories
  • 24cf406 Update VRT screenshots

📊 Changes

10 files changed (+165 additions, -67 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/BudgetCategories.tsx (+135 -51)
📝 packages/desktop-client/src/components/budget/BudgetTable.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/ExpenseCategory.tsx (+4 -4)
📝 packages/desktop-client/src/components/budget/ExpenseGroup.tsx (+6 -1)
📝 packages/desktop-client/src/components/budget/IncomeGroup.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+2 -0)
📝 packages/desktop-client/src/components/sort.tsx (+4 -4)
➕ upcoming-release-notes/5961.md (+7 -0)

📄 Description

Part of #1483

Converted packages/desktop-client/src/components/budget/BudgetCategories.jsx to TypeScript.

Changes

  • Renamed BudgetCategories.jsx → BudgetCategories.tsx
  • Added comprehensive type definitions for all props and internal types
  • Added proper typing for drag state, budget items, and callbacks
  • Updated BudgetTable.tsx to properly handle the typed component
  • Fixed callback signatures to match expected types
  • All typecheck and lint checks pass

Testing

  • ✅ Type checking passes
  • ✅ Linting passes
  • ✅ No runtime errors introduced

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5961 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/18/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/ts-budget-categories` --- ### 📝 Commits (10+) - [`e057301`](https://github.com/actualbudget/actual/commit/e0573019142ea1f7ea1a11b5ff36ef447e4de92b) move to tsx - [`3cf50d7`](https://github.com/actualbudget/actual/commit/3cf50d7907366f9333cb159cd6b157b464f61cf9) refactor: update types in BudgetCategories and sort components - [`5d39f78`](https://github.com/actualbudget/actual/commit/5d39f78de9b2e63469ce8fc6dcd64f37a8f958fb) Add release notes - [`8978652`](https://github.com/actualbudget/actual/commit/8978652082cf99e528ebd899241a11aa60d4d131) refactor: enhance type definitions in budget components - [`7a31b70`](https://github.com/actualbudget/actual/commit/7a31b7088f5d1b462c8c3dae72325bfb8d9e9a1f) Merge branch 'master' into matiss/ts-budget-categories - [`149445d`](https://github.com/actualbudget/actual/commit/149445d47325c6a6019335469863a766202dd566) refactor: improve type definitions in budget components - [`88c5e15`](https://github.com/actualbudget/actual/commit/88c5e157dd582672c52578f11fb9951c95c87da2) Merge branch 'matiss/ts-budget-categories' of github.com:actualbudget/actual into matiss/ts-budget-categories - [`744df7e`](https://github.com/actualbudget/actual/commit/744df7e7a40a6fa0c45191aee108362560e3ef9f) Fix: Allow reordering categories to null target - [`f69b88c`](https://github.com/actualbudget/actual/commit/f69b88cca2e9c014269aa9f4d07dc5f26151cedb) Merge branch 'master' into matiss/ts-budget-categories - [`24cf406`](https://github.com/actualbudget/actual/commit/24cf4060929eaed0c6143f71781600a9c280ddb4) Update VRT screenshots ### 📊 Changes **10 files changed** (+165 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/BudgetCategories.tsx` (+135 -51) 📝 `packages/desktop-client/src/components/budget/BudgetTable.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/ExpenseCategory.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/budget/ExpenseGroup.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/budget/IncomeGroup.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/sort.tsx` (+4 -4) ➕ `upcoming-release-notes/5961.md` (+7 -0) </details> ### 📄 Description Part of #1483 Converted `packages/desktop-client/src/components/budget/BudgetCategories.jsx` to TypeScript. ## Changes - Renamed `BudgetCategories.jsx` → `BudgetCategories.tsx` - Added comprehensive type definitions for all props and internal types - Added proper typing for drag state, budget items, and callbacks - Updated `BudgetTable.tsx` to properly handle the typed component - Fixed callback signatures to match expected types - All typecheck and lint checks pass ## Testing - ✅ Type checking passes - ✅ Linting passes - ✅ No runtime errors introduced --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-22 11:44:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#88420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?