github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-20 22:21:38 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #7890] [MERGED] use separate_continuous_history_consent flag from GoCardless #85152

New Issue
Closed
opened 2026-05-19 10:31:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 10:31:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7890
Author: @matt-fidd
Created: 5/18/2026
Status: ✅ Merged
Merged: 5/18/2026
Merged by: @matt-fidd

Base: master ← Head: gocardless/continuous-access

📝 Commits (5)

  • 0d6e599 use separate_continuous_history_consent flag from GoCardless
  • 8664e14 add logging for GCL
  • c576a86 note
  • 47fe739 test
  • 639821b Merge branch 'master' into gocardless/continuous-access

📊 Changes

5 files changed (+83 additions, -169 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/bank-factory.js (+0 -163)
📝 packages/sync-server/src/app-gocardless/gocardless-node.types.ts (+17 -1)
📝 packages/sync-server/src/app-gocardless/services/gocardless-service.ts (+29 -5)
📝 packages/sync-server/src/app-gocardless/services/tests/gocardless-service.spec.js (+31 -0)
➕ upcoming-release-notes/7890.md (+6 -0)

📄 Description

Description

I originally grabbed this array from GoCardless, but it looks like there were some mistakes in it and some of the IDs were incorrect. They've now introduced a flag that we can use to detect this behaviour so I just cleaned up to use that instead.

GoCardless also frequently ask for information that isn't the easiest to grab, so I've added in some logging when reqiuisitions are created to make that process easier. Sample output (id's redacted, but they're useless without API keys anyway):

GoCardless requisition request: {
  institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A',
  accessValidForDays: '180',
  maxHistoricalDays: 90,
  transactionTotalDays: '365',
  separateContinuousHistoryConsent: true,
  accountSelection: true,
  supportedFeatures: [
    'account_selection',
    'business_accounts',
    'corporate_accounts',
    'private_accounts',
    'separate_continuous_history_consent'
  ]
}
GoCardless requisition created: {
  institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A',
  requisitionId: 'xxxx-xxxx-xxxx-xxxx',
  agreementId: 'xxxx-xxxx-xxxx-xxxx'
}
GoCardless requisition linked: {
  institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A',
  requisitionId: 'xxxx-xxxx-xxxx-xxxx',
  agreementId: 'xxxx-xxxx-xxxx-xxxx',
  accountIds: [ 'xxxx-xxxx-xxxx-xxxx' ]
}

Related issue(s)

Fixes https://discord.com/channels/937901803608096828/1480188258586726451

Testing

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7890 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 5/18/2026 **Status:** ✅ Merged **Merged:** 5/18/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `gocardless/continuous-access` --- ### 📝 Commits (5) - [`0d6e599`](https://github.com/actualbudget/actual/commit/0d6e59929943c61ac548c195a6aea64db6da9232) use separate_continuous_history_consent flag from GoCardless - [`8664e14`](https://github.com/actualbudget/actual/commit/8664e14a95059c8d1886e212d7d6a826499103de) add logging for GCL - [`c576a86`](https://github.com/actualbudget/actual/commit/c576a8673fbc88bfac89fda618bff8b0fc465a9c) note - [`47fe739`](https://github.com/actualbudget/actual/commit/47fe7393a90fb20057f4a02ca970c1c8c4abd4aa) test - [`639821b`](https://github.com/actualbudget/actual/commit/639821b9bb0f1c73338149c5ceb3552cccfbe037) Merge branch 'master' into gocardless/continuous-access ### 📊 Changes **5 files changed** (+83 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/bank-factory.js` (+0 -163) 📝 `packages/sync-server/src/app-gocardless/gocardless-node.types.ts` (+17 -1) 📝 `packages/sync-server/src/app-gocardless/services/gocardless-service.ts` (+29 -5) 📝 `packages/sync-server/src/app-gocardless/services/tests/gocardless-service.spec.js` (+31 -0) ➕ `upcoming-release-notes/7890.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://actualbudget.org/docs/contributing/#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> I originally grabbed this array from GoCardless, but it looks like there were some mistakes in it and some of the IDs were incorrect. They've now introduced a flag that we can use to detect this behaviour so I just cleaned up to use that instead. GoCardless also frequently ask for information that isn't the easiest to grab, so I've added in some logging when reqiuisitions are created to make that process easier. Sample output (id's redacted, but they're useless without API keys anyway): ``` GoCardless requisition request: { institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A', accessValidForDays: '180', maxHistoricalDays: 90, transactionTotalDays: '365', separateContinuousHistoryConsent: true, accountSelection: true, supportedFeatures: [ 'account_selection', 'business_accounts', 'corporate_accounts', 'private_accounts', 'separate_continuous_history_consent' ] } GoCardless requisition created: { institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A', requisitionId: 'xxxx-xxxx-xxxx-xxxx', agreementId: 'xxxx-xxxx-xxxx-xxxx' } GoCardless requisition linked: { institutionId: 'CREDITO_COOPERATIVO_CASSA_RURALE_ED_ARTIGIANA_DEL_FRIULI_VENEZIA_GIULIA_CCRTIT2T96A', requisitionId: 'xxxx-xxxx-xxxx-xxxx', agreementId: 'xxxx-xxxx-xxxx-xxxx', accountIds: [ 'xxxx-xxxx-xxxx-xxxx' ] } ``` ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> Fixes https://discord.com/channels/937901803608096828/1480188258586726451 ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 10:31:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#85152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?