github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-21 06:31:58 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #7859] [MERGED] [AI] Prevent CSV formula injection in exports and CLI output #85125

New Issue
Closed
opened 2026-05-19 10:29:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 10:29:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7859
Author: @MatissJanis
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/16/2026
Merged by: @MatissJanis

Base: master ← Head: claude/fix-csv-escaping-4M6I6

📝 Commits (7)

  • 48699c4 [AI] Neutralize CSV formula-injection in CLI output and transaction export
  • 4264a47 [AI] Simplify CSV formula-injection guard
  • a165a42 [AI] Remove @ts-strict-ignore from export-to-csv test
  • 2d36514 [AI] Add release notes for CSV formula-injection fix
  • 24a549a [AI] Quote CSV cells containing carriage returns
  • 74fb352 [autofix.ci] apply automated fixes
  • 0375ded [AI] Rephrase release note in user-facing language

📊 Changes

5 files changed (+142 additions, -7 deletions)

View changed files

📝 packages/cli/src/output.test.ts (+44 -0)
📝 packages/cli/src/output.ts (+20 -5)
➕ packages/loot-core/src/server/transactions/export/export-to-csv.test.ts (+60 -0)
📝 packages/loot-core/src/server/transactions/export/export-to-csv.ts (+12 -2)
➕ upcoming-release-notes/7859.md (+6 -0)

📄 Description

Description

Patch CSV template injection attacks in the @actual-app/cli

https://github.com/actualbudget/actual/security/advisories/GHSA-7gh7-258j-4mpq

Testing

n/a

Checklist

  • Release notes added
  • Unit tests added for both export and CLI output paths
  • Self-review performed

https://claude.ai/code/session_01F19t1ipDELozVWN1t1tBhy

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.99 MB 0%
loot-core 1 5.34 MB → 5.34 MB (+177 B) +0.00%
api 2 3.96 MB → 3.96 MB (+172 B) +0.00%
cli 1 7.97 MB → 7.97 MB (+249 B) +0.00%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.99 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 2.01 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.25 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 190.43 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.97 MB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.62 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.17 kB 0%
static/js/de.js 170.27 kB 0%
static/js/en-GB.js 10.01 kB 0%
static/js/en.js 195.88 kB 0%
static/js/es.js 178.71 kB 0%
static/js/extends.js 519.29 kB 0%
static/js/fr.js 178.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.02 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.08 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 189.28 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.45 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.65 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB → 5.34 MB (+177 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts 📈 +177 B (+6.57%) 2.63 kB → 2.81 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BDS7YpIF.js 0 B → 5.34 MB (+5.34 MB) -

Removed

Asset File Size % Changed
kcab.worker.C0Ijh3nP.js 5.34 MB → 0 B (-5.34 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.96 MB → 3.96 MB (+172 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts 📈 +172 B (+6.51%) 2.58 kB → 2.75 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.96 MB → 3.96 MB (+172 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB → 7.97 MB (+249 B) +0.00%
Changeset
File Δ Size
src/output.ts 📈 +249 B (+11.20%) 2.17 kB → 2.41 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
cli.js 7.97 MB → 7.97 MB (+249 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7859 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/16/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/fix-csv-escaping-4M6I6` --- ### 📝 Commits (7) - [`48699c4`](https://github.com/actualbudget/actual/commit/48699c46b1b5cc296bc76dd637edb47b0c02d926) [AI] Neutralize CSV formula-injection in CLI output and transaction export - [`4264a47`](https://github.com/actualbudget/actual/commit/4264a47528aae85687581b70cd3086074206e93a) [AI] Simplify CSV formula-injection guard - [`a165a42`](https://github.com/actualbudget/actual/commit/a165a42ee6e3f09349ef5af8acc2620820ff8b21) [AI] Remove @ts-strict-ignore from export-to-csv test - [`2d36514`](https://github.com/actualbudget/actual/commit/2d3651460b03fd29398d46725632fb9abb984e9d) [AI] Add release notes for CSV formula-injection fix - [`24a549a`](https://github.com/actualbudget/actual/commit/24a549a8e1f471b6f64b14c15d7fc2540e3b29b3) [AI] Quote CSV cells containing carriage returns - [`74fb352`](https://github.com/actualbudget/actual/commit/74fb3520507ecf1348d37f33bbf05e58847479f4) [autofix.ci] apply automated fixes - [`0375ded`](https://github.com/actualbudget/actual/commit/0375ded8caacab6ae108d2487f409b8ab25e2404) [AI] Rephrase release note in user-facing language ### 📊 Changes **5 files changed** (+142 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/cli/src/output.test.ts` (+44 -0) 📝 `packages/cli/src/output.ts` (+20 -5) ➕ `packages/loot-core/src/server/transactions/export/export-to-csv.test.ts` (+60 -0) 📝 `packages/loot-core/src/server/transactions/export/export-to-csv.ts` (+12 -2) ➕ `upcoming-release-notes/7859.md` (+6 -0) </details> ### 📄 Description ## Description Patch CSV template injection attacks in the `@actual-app/cli` https://github.com/actualbudget/actual/security/advisories/GHSA-7gh7-258j-4mpq ## Testing n/a ## Checklist - [x] Release notes added - [x] Unit tests added for both export and CLI output paths - [x] Self-review performed https://claude.ai/code/session_01F19t1ipDELozVWN1t1tBhy <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.99 MB | 0% loot-core | 1 | 5.34 MB → 5.34 MB (+177 B) | +0.00% api | 2 | 3.96 MB → 3.96 MB (+172 B) | +0.00% cli | 1 | 7.97 MB → 7.97 MB (+249 B) | +0.00% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.99 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 2.01 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 190.43 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.97 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.62 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.17 kB | 0% static/js/de.js | 170.27 kB | 0% static/js/en-GB.js | 10.01 kB | 0% static/js/en.js | 195.88 kB | 0% static/js/es.js | 178.71 kB | 0% static/js/extends.js | 519.29 kB | 0% static/js/fr.js | 178.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.02 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.08 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 189.28 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.45 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.65 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB → 5.34 MB (+177 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts` | 📈 +177 B (+6.57%) | 2.63 kB → 2.81 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BDS7YpIF.js | 0 B → 5.34 MB (+5.34 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C0Ijh3nP.js | 5.34 MB → 0 B (-5.34 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB → 3.96 MB (+172 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts` | 📈 +172 B (+6.51%) | 2.58 kB → 2.75 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB → 3.96 MB (+172 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB → 7.97 MB (+249 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/output.ts` | 📈 +249 B (+11.20%) | 2.17 kB → 2.41 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB → 7.97 MB (+249 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 10:29:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#85125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?