github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7851] [MERGED] [AI] Convert built-in themes from TypeScript to CSS files #85119

New Issue
Closed
opened 2026-05-19 10:29:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 10:29:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7851
Author: @MatissJanis
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/16/2026
Merged by: @MatissJanis

Base: master ← Head: claude/convert-theme-css-variables-BGOKo

📝 Commits (4)

  • 5267ed2 [AI] Convert theme color TS modules to CSS files with CSS variables
  • 88c3e11 [AI] Move theme CSS files to component-library
  • d13918b [AI] Minimize theme.tsx rename churn
  • 6340e11 [AI] Add release note for theme CSS conversion

📊 Changes

12 files changed (+889 additions, -877 deletions)

View changed files

📝 packages/component-library/.storybook/preview.tsx (+9 -16)
📝 packages/component-library/package.json (+4 -0)
➕ packages/component-library/src/themes/dark.css (+250 -0)
➕ packages/component-library/src/themes/light.css (+250 -0)
➕ packages/component-library/src/themes/midnight.css (+252 -0)
➕ packages/component-library/src/themes/palette.css (+103 -0)
➖ packages/desktop-client/src/style/palette.ts (+0 -96)
📝 packages/desktop-client/src/style/theme.tsx (+15 -14)
➖ packages/desktop-client/src/style/themes/dark.ts (+0 -249)
➖ packages/desktop-client/src/style/themes/light.ts (+0 -251)
➖ packages/desktop-client/src/style/themes/midnight.ts (+0 -251)
➕ upcoming-release-notes/7851.md (+6 -0)

📄 Description

Description

Moving TypeScript theme definitions to just plain old CSS.

Two core reasons:

  • CSS variables allow for inheritance, so adding new variables will be possible without breaking all the existing themes
  • fixes the cross-package import we have in component-library

Related issue(s)

https://github.com/actualbudget/actual/pull/7841

Testing

  • Existing theme functionality remains unchanged; themes are injected via CSS instead of TypeScript
  • Storybook continues to work with the new CSS-based theme system
  • No breaking changes to the public API

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed

https://claude.ai/code/session_01CgeeWgmqUmj2qhbwevGdxa

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.99 MB → 13.97 MB (-18.93 kB) -0.13%
loot-core 1 5.34 MB 0%
api 2 3.96 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.99 MB → 13.97 MB (-18.93 kB) -0.13%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/component-library/src/themes/midnight.css?inline 🆕 +12.65 kB 0 B → 12.65 kB
home/runner/work/actual/actual/packages/component-library/src/themes/light.css?inline 🆕 +12.53 kB 0 B → 12.53 kB
home/runner/work/actual/actual/packages/component-library/src/themes/dark.css?inline 🆕 +12.51 kB 0 B → 12.51 kB
home/runner/work/actual/actual/packages/component-library/src/themes/palette.css?inline 🆕 +3 kB 0 B → 3 kB
src/style/theme.tsx 📈 +40 B (+0.47%) 8.37 kB → 8.41 kB
src/hooks/useGlobalPref.ts 📉 -58 B (-11.86%) 489 B → 431 B
src/style/themes/light.ts 🔥 -19.53 kB (-100%) 19.53 kB → 0 B
src/style/themes/dark.ts 🔥 -19.34 kB (-100%) 19.34 kB → 0 B
src/style/themes/midnight.ts 🔥 -18.71 kB (-100%) 18.71 kB → 0 B
src/style/palette.ts 🔥 -2.02 kB (-100%) 2.02 kB → 0 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/extends.js 519.29 kB → 500.36 kB (-18.93 kB) -3.65%

Unchanged

Asset File Size % Changed
static/js/index.js 2.01 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.25 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionEdit.js 190.43 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.97 MB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.72 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.28 kB 0%
static/js/de.js 170.38 kB 0%
static/js/en-GB.js 10.01 kB 0%
static/js/en.js 195.44 kB 0%
static/js/es.js 178.83 kB 0%
static/js/fr.js 178.71 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.13 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.19 kB 0%
static/js/nl.js 106.34 kB 0%
static/js/pt-BR.js 189.39 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.62 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.56 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.75 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.C0Ijh3nP.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.96 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.96 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7851 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/16/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/convert-theme-css-variables-BGOKo` --- ### 📝 Commits (4) - [`5267ed2`](https://github.com/actualbudget/actual/commit/5267ed2f982cc685092b01bc6d4b57235c10860e) [AI] Convert theme color TS modules to CSS files with CSS variables - [`88c3e11`](https://github.com/actualbudget/actual/commit/88c3e1195d2598efe7ad7156edf80060f6986ebd) [AI] Move theme CSS files to component-library - [`d13918b`](https://github.com/actualbudget/actual/commit/d13918bcd8e882fb755a25a85b7458f7d37485a2) [AI] Minimize theme.tsx rename churn - [`6340e11`](https://github.com/actualbudget/actual/commit/6340e114abde1c3c1e27616c6abdeb6b0dd3733d) [AI] Add release note for theme CSS conversion ### 📊 Changes **12 files changed** (+889 additions, -877 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/.storybook/preview.tsx` (+9 -16) 📝 `packages/component-library/package.json` (+4 -0) ➕ `packages/component-library/src/themes/dark.css` (+250 -0) ➕ `packages/component-library/src/themes/light.css` (+250 -0) ➕ `packages/component-library/src/themes/midnight.css` (+252 -0) ➕ `packages/component-library/src/themes/palette.css` (+103 -0) ➖ `packages/desktop-client/src/style/palette.ts` (+0 -96) 📝 `packages/desktop-client/src/style/theme.tsx` (+15 -14) ➖ `packages/desktop-client/src/style/themes/dark.ts` (+0 -249) ➖ `packages/desktop-client/src/style/themes/light.ts` (+0 -251) ➖ `packages/desktop-client/src/style/themes/midnight.ts` (+0 -251) ➕ `upcoming-release-notes/7851.md` (+6 -0) </details> ### 📄 Description ## Description Moving TypeScript theme definitions to just plain old CSS. Two core reasons: - CSS variables allow for inheritance, so adding new variables will be possible without breaking all the existing themes - fixes the cross-package import we have in component-library ## Related issue(s) https://github.com/actualbudget/actual/pull/7841 ## Testing - Existing theme functionality remains unchanged; themes are injected via CSS instead of TypeScript - Storybook continues to work with the new CSS-based theme system - No breaking changes to the public API ## Checklist - [x] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed https://claude.ai/code/session_01CgeeWgmqUmj2qhbwevGdxa <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.99 MB → 13.97 MB (-18.93 kB) | -0.13% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.96 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.99 MB → 13.97 MB (-18.93 kB) | -0.13% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/component-library/src/themes/midnight.css?inline` | 🆕 +12.65 kB | 0 B → 12.65 kB `home/runner/work/actual/actual/packages/component-library/src/themes/light.css?inline` | 🆕 +12.53 kB | 0 B → 12.53 kB `home/runner/work/actual/actual/packages/component-library/src/themes/dark.css?inline` | 🆕 +12.51 kB | 0 B → 12.51 kB `home/runner/work/actual/actual/packages/component-library/src/themes/palette.css?inline` | 🆕 +3 kB | 0 B → 3 kB `src/style/theme.tsx` | 📈 +40 B (+0.47%) | 8.37 kB → 8.41 kB `src/hooks/useGlobalPref.ts` | 📉 -58 B (-11.86%) | 489 B → 431 B `src/style/themes/light.ts` | 🔥 -19.53 kB (-100%) | 19.53 kB → 0 B `src/style/themes/dark.ts` | 🔥 -19.34 kB (-100%) | 19.34 kB → 0 B `src/style/themes/midnight.ts` | 🔥 -18.71 kB (-100%) | 18.71 kB → 0 B `src/style/palette.ts` | 🔥 -2.02 kB (-100%) | 2.02 kB → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/extends.js | 519.29 kB → 500.36 kB (-18.93 kB) | -3.65% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 2.01 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.25 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 190.43 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.97 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.72 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.28 kB | 0% static/js/de.js | 170.38 kB | 0% static/js/en-GB.js | 10.01 kB | 0% static/js/en.js | 195.44 kB | 0% static/js/es.js | 178.83 kB | 0% static/js/fr.js | 178.71 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.13 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.19 kB | 0% static/js/nl.js | 106.34 kB | 0% static/js/pt-BR.js | 189.39 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.62 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.56 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.75 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C0Ijh3nP.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 10:29:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#85119