github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7766] [WIP] [AI] fix: set parent transaction payee to null when splitting #85054

New Issue
Open
opened 2026-05-19 10:23:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 10:23:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7766
Author: @xxiaoxiong
Created: 5/9/2026
Status: 🔄 Open

Base: master ← Head: fix/split-transaction-payee

📝 Commits (5)

  • 752ef30 [AI] feat: add persistent SharedArrayBuffer warning indicator
  • ce468ca [AI] fix: wrap desktop TransactionList with DisplayPayeeProvider in Calendar
  • 6a6bc37 [AI] fix: set parent transaction payee to null when splitting
  • 846e129 [autofix.ci] apply automated fixes
  • 65f66a3 fix: set child payee to null when splitting to match parent

📊 Changes

4 files changed (+114 additions, -52 deletions)

View changed files

📝 packages/desktop-client/src/components/Titlebar.tsx (+44 -0)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+53 -51)
📝 packages/loot-core/src/shared/transactions.test.ts (+15 -0)
📝 packages/loot-core/src/shared/transactions.ts (+2 -1)

📄 Description

Summary

Fixes a data consistency issue where split transactions retain the original payee in the parent transaction, even though semantically only child transactions should have payees.

Problem

When splitting a transaction:

  1. Original transaction has payee "Foo"
  2. After splitting, parent still has payee "Foo" in the database
  3. If all children are changed to different payees (e.g., "Bar"), the UI correctly shows "Bar" for the parent
  4. However, searching for "Foo" still finds this transaction (even though "Foo" appears nowhere in the UI)
  5. The payee "Foo" incorrectly appears as "in use" in the payee list

Root Cause

In splitTransaction() function (packages/loot-core/src/shared/transactions.ts), when creating the parent transaction, the code used:

return {
  ...rest,  // This includes the original payee
  is_parent: true,
  ...
}

The ...rest spread operator preserved all original transaction properties, including the payee field.

Solution

Explicitly set payee: null when creating the parent transaction:

return {
  ...rest,
  payee: null,  // Clear the payee for parent transactions
  is_parent: true,
  ...
}

Changes

  • packages/loot-core/src/shared/transactions.ts: Added payee: null in splitTransaction()
  • packages/loot-core/src/shared/transactions.test.ts: Added test to verify parent payee is cleared

Testing

  • Added unit test that verifies parent transaction has payee: null after splitting
  • Test creates a transaction with a payee, splits it, and confirms the parent payee is null
  • Existing tests continue to pass

Impact

  • Fixes incorrect payee search results
  • Fixes incorrect "payee in use" status
  • Improves data consistency between UI and database
  • No breaking changes - only affects newly split transactions

Fixes #7721

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 13.93 MB → 13.93 MB (+1.57 kB) +0.01%
loot-core 1 5.27 MB → 5.27 MB (+17 B) +0.00%
api 2 3.9 MB → 3.9 MB (+16 B) +0.00%
cli 1 7.97 MB 0%
crdt 1 43.41 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 13.93 MB → 13.93 MB (+1.57 kB) +0.01%
Changeset
File Δ Size
src/components/Titlebar.tsx 📈 +1.38 kB (+11.55%) 11.93 kB → 13.31 kB
src/components/reports/reports/Calendar.tsx 📈 +182 B (+0.64%) 27.58 kB → 27.76 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +16 B (+0.19%) 8.17 kB → 8.18 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 1.93 MB → 1.93 MB (+1.38 kB) +0.07%
static/js/ReportRouter.js 1.22 MB → 1.22 MB (+182 B) +0.01%
static/js/Value.js 4.94 MB → 4.94 MB (+16 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ScheduleEditForm.js 145.76 kB 0%
static/js/TransactionEdit.js 189.54 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/alerts.js 800.08 kB 0%
static/js/bankSyncUtils.js 54.1 kB 0%
static/js/ca.js 187.91 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.38 kB 0%
static/js/de.js 170.55 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 185.11 kB 0%
static/js/es.js 179 kB 0%
static/js/extends.js 520.14 kB 0%
static/js/fr.js 178.9 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.01 kB 0%
static/js/narrow.js 364.41 kB 0%
static/js/nb-NO.js 148.31 kB 0%
static/js/nl.js 106.47 kB 0%
static/js/pl.js 86.52 kB 0%
static/js/pt-BR.js 189.58 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.76 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.75 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.91 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB → 5.27 MB (+17 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +17 B (+0.27%) 6.05 kB → 6.06 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.D9bogXyd.js 0 B → 5.27 MB (+5.27 MB) -

Removed

Asset File Size % Changed
kcab.worker.hJfPtoKI.js 5.27 MB → 0 B (-5.27 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.9 MB → 3.9 MB (+16 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +16 B (+0.27%) 5.85 kB → 5.86 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.9 MB → 3.9 MB (+16 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 43.41 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 43.41 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7766 **Author:** [@xxiaoxiong](https://github.com/xxiaoxiong) **Created:** 5/9/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/split-transaction-payee` --- ### 📝 Commits (5) - [`752ef30`](https://github.com/actualbudget/actual/commit/752ef302cd64e1d0c604f199c5547404d20e6e58) [AI] feat: add persistent SharedArrayBuffer warning indicator - [`ce468ca`](https://github.com/actualbudget/actual/commit/ce468caf9a753678eb6fe6a7adf184c729e2c805) [AI] fix: wrap desktop TransactionList with DisplayPayeeProvider in Calendar - [`6a6bc37`](https://github.com/actualbudget/actual/commit/6a6bc375624e4a5d5eadfa0e5b199c1a2896c745) [AI] fix: set parent transaction payee to null when splitting - [`846e129`](https://github.com/actualbudget/actual/commit/846e129e86c4701e190769ef9cb724507df26673) [autofix.ci] apply automated fixes - [`65f66a3`](https://github.com/actualbudget/actual/commit/65f66a3450be42468eb2b4d2fa8a4f2ff8d4294e) fix: set child payee to null when splitting to match parent ### 📊 Changes **4 files changed** (+114 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+44 -0) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+53 -51) 📝 `packages/loot-core/src/shared/transactions.test.ts` (+15 -0) 📝 `packages/loot-core/src/shared/transactions.ts` (+2 -1) </details> ### 📄 Description ## Summary Fixes a data consistency issue where split transactions retain the original payee in the parent transaction, even though semantically only child transactions should have payees. ## Problem When splitting a transaction: 1. Original transaction has payee "Foo" 2. After splitting, parent still has payee "Foo" in the database 3. If all children are changed to different payees (e.g., "Bar"), the UI correctly shows "Bar" for the parent 4. However, searching for "Foo" still finds this transaction (even though "Foo" appears nowhere in the UI) 5. The payee "Foo" incorrectly appears as "in use" in the payee list ## Root Cause In `splitTransaction()` function (packages/loot-core/src/shared/transactions.ts), when creating the parent transaction, the code used: ```typescript return { ...rest, // This includes the original payee is_parent: true, ... } ``` The `...rest` spread operator preserved all original transaction properties, including the `payee` field. ## Solution Explicitly set `payee: null` when creating the parent transaction: ```typescript return { ...rest, payee: null, // Clear the payee for parent transactions is_parent: true, ... } ``` ## Changes - **packages/loot-core/src/shared/transactions.ts**: Added `payee: null` in `splitTransaction()` - **packages/loot-core/src/shared/transactions.test.ts**: Added test to verify parent payee is cleared ## Testing - Added unit test that verifies parent transaction has `payee: null` after splitting - Test creates a transaction with a payee, splits it, and confirms the parent payee is null - Existing tests continue to pass ## Impact - Fixes incorrect payee search results - Fixes incorrect "payee in use" status - Improves data consistency between UI and database - No breaking changes - only affects newly split transactions Fixes #7721 <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 13.93 MB → 13.93 MB (+1.57 kB) | +0.01% loot-core | 1 | 5.27 MB → 5.27 MB (+17 B) | +0.00% api | 2 | 3.9 MB → 3.9 MB (+16 B) | +0.00% cli | 1 | 7.97 MB | 0% crdt | 1 | 43.41 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 13.93 MB → 13.93 MB (+1.57 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/Titlebar.tsx` | 📈 +1.38 kB (+11.55%) | 11.93 kB → 13.31 kB `src/components/reports/reports/Calendar.tsx` | 📈 +182 B (+0.64%) | 27.58 kB → 27.76 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +16 B (+0.19%) | 8.17 kB → 8.18 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.93 MB → 1.93 MB (+1.38 kB) | +0.07% static/js/ReportRouter.js | 1.22 MB → 1.22 MB (+182 B) | +0.01% static/js/Value.js | 4.94 MB → 4.94 MB (+16 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ScheduleEditForm.js | 145.76 kB | 0% static/js/TransactionEdit.js | 189.54 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/alerts.js | 800.08 kB | 0% static/js/bankSyncUtils.js | 54.1 kB | 0% static/js/ca.js | 187.91 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.38 kB | 0% static/js/de.js | 170.55 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 185.11 kB | 0% static/js/es.js | 179 kB | 0% static/js/extends.js | 520.14 kB | 0% static/js/fr.js | 178.9 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.01 kB | 0% static/js/narrow.js | 364.41 kB | 0% static/js/nb-NO.js | 148.31 kB | 0% static/js/nl.js | 106.47 kB | 0% static/js/pl.js | 86.52 kB | 0% static/js/pt-BR.js | 189.58 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.76 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.75 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.91 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB → 5.27 MB (+17 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +17 B (+0.27%) | 6.05 kB → 6.06 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.D9bogXyd.js | 0 B → 5.27 MB (+5.27 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.hJfPtoKI.js | 5.27 MB → 0 B (-5.27 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.9 MB → 3.9 MB (+16 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +16 B (+0.27%) | 5.85 kB → 5.86 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.9 MB → 3.9 MB (+16 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 43.41 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 43.41 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 10:23:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#85054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?