github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7714] [AI] Fix mobile split amount focus #85021

New Issue
Open
opened 2026-05-19 10:21:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 10:21:12 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7714
Author: @aqilaziz
Created: 5/4/2026
Status: 🔄 Open

Base: master ← Head: fix-mobile-split-amount-focus-ai

📝 Commits (3)

  • 3d64498 [AI] Fix mobile split amount focus
  • 000d5e3 [AI] Add release note for mobile split focus
  • 8102ef0 [AI] Address mobile amount focus review

📊 Changes

2 files changed (+28 additions, -8 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+22 -8)
➕ upcoming-release-notes/7714.md (+6 -0)

📄 Description

Description

Fixes the mobile split transaction amount input focus behavior when editing split transactions. The amount field now uses a dedicated ref/effect to focus only the active amount input and blur it when active editing moves away, preventing focus from jumping to a different input after pressing Enter.

Related issue(s)

Fixes #3933

Testing

  • corepack yarn oxfmt --check packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx upcoming-release-notes/7714.md
  • corepack yarn oxlint --type-aware --quiet packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 13.96 MB → 13.96 MB (+662 B) +0.00%
loot-core 1 5.27 MB 0%
api 2 3.89 MB 0%
cli 1 7.97 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 13.96 MB → 13.96 MB (+662 B) +0.00%
Changeset
File Δ Size
src/components/mobile/transactions/TransactionEdit.tsx 📈 +662 B (+1.01%) 64.06 kB → 64.7 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/TransactionEdit.js 189.54 kB → 190.18 kB (+662 B) +0.34%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.93 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/alerts.js 800.08 kB 0%
static/js/bankSyncUtils.js 53.96 kB 0%
static/js/ca.js 190.22 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 103.32 kB 0%
static/js/de.js 172.83 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 185.81 kB 0%
static/js/es.js 181.26 kB 0%
static/js/extends.js 518.66 kB 0%
static/js/fr.js 181.27 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 167.28 kB 0%
static/js/narrow.js 364.02 kB 0%
static/js/nb-NO.js 150.48 kB 0%
static/js/nl.js 108.23 kB 0%
static/js/pl.js 88.01 kB 0%
static/js/pt-BR.js 192.06 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.2 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 210.75 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 119.2 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.DiBErB6z.js 5.27 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7714 **Author:** [@aqilaziz](https://github.com/aqilaziz) **Created:** 5/4/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-mobile-split-amount-focus-ai` --- ### 📝 Commits (3) - [`3d64498`](https://github.com/actualbudget/actual/commit/3d644987ba4aab76567d0d5f4614103d2e7c5aa4) [AI] Fix mobile split amount focus - [`000d5e3`](https://github.com/actualbudget/actual/commit/000d5e3f492885d4f9cdfae7277dbbaa3625a9f2) [AI] Add release note for mobile split focus - [`8102ef0`](https://github.com/actualbudget/actual/commit/8102ef0e377a2b6bf2935f4c9d7cf0d8a331c4dc) [AI] Address mobile amount focus review ### 📊 Changes **2 files changed** (+28 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+22 -8) ➕ `upcoming-release-notes/7714.md` (+6 -0) </details> ### 📄 Description ## Description Fixes the mobile split transaction amount input focus behavior when editing split transactions. The amount field now uses a dedicated ref/effect to focus only the active amount input and blur it when active editing moves away, preventing focus from jumping to a different input after pressing Enter. ## Related issue(s) Fixes #3933 ## Testing - `corepack yarn oxfmt --check packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx upcoming-release-notes/7714.md` - `corepack yarn oxlint --type-aware --quiet packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 13.96 MB → 13.96 MB (+662 B) | +0.00% loot-core | 1 | 5.27 MB | 0% api | 2 | 3.89 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 13.96 MB → 13.96 MB (+662 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/mobile/transactions/TransactionEdit.tsx` | 📈 +662 B (+1.01%) | 64.06 kB → 64.7 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/TransactionEdit.js | 189.54 kB → 190.18 kB (+662 B) | +0.34% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.93 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/alerts.js | 800.08 kB | 0% static/js/bankSyncUtils.js | 53.96 kB | 0% static/js/ca.js | 190.22 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 103.32 kB | 0% static/js/de.js | 172.83 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 185.81 kB | 0% static/js/es.js | 181.26 kB | 0% static/js/extends.js | 518.66 kB | 0% static/js/fr.js | 181.27 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 167.28 kB | 0% static/js/narrow.js | 364.02 kB | 0% static/js/nb-NO.js | 150.48 kB | 0% static/js/nl.js | 108.23 kB | 0% static/js/pl.js | 88.01 kB | 0% static/js/pt-BR.js | 192.06 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.2 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 210.75 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 119.2 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DiBErB6z.js | 5.27 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 10:21:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#85021