github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-20 22:21:38 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #5858] [MERGED] ♻️ bump non-react deps in desktop-client #83850

New Issue
Closed
opened 2026-05-19 08:48:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-19 08:48:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5858
Author: @matt-fidd
Created: 10/5/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @matt-fidd

Base: master ← Head: deps/not-react

📝 Commits (9)

📊 Changes

16 files changed (+520 additions, -440 deletions)

View changed files

📝 .github/workflows/e2e-test.yml (+3 -3)
📝 .github/workflows/update-vrt.yml (+1 -1)
📝 bin/run-vrt (+1 -1)
📝 package.json (+1 -1)
📝 packages/desktop-client/README.md (+2 -2)
📝 packages/desktop-client/index.html (+0 -4)
📝 packages/desktop-client/package.json (+14 -16)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+108 -96)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx (+22 -14)
📝 packages/desktop-client/src/components/forms.tsx (+1 -1)
📝 packages/desktop-client/src/index.tsx (+0 -3)
📝 packages/desktop-client/vite.config.mts (+1 -0)
📝 packages/desktop-electron/package.json (+2 -2)
📝 packages/loot-core/package.json (+4 -4)
➕ upcoming-release-notes/5858.md (+6 -0)
📝 yarn.lock (+354 -292)

📄 Description

Wow, this was a tough one 😅

Chosen to drop two dependencies:

  • chokidar was not used
  • focus-visible has been supported in all major browsers for a couple of years now, we don't need the polyfill anymore

Code changes:

  • Drop focus-visible
  • Some downshift types changed, so there's some fiddling with getInputProps in Autocomplete
  • jsdom changing the selector library under the hood has messed with some tests
  • update playwright versions

I couldn't get recharts v3 or inter-ui v4 to play ball, those will have to be seperate PRs when I get a chance. Hopefully I can get the react change working soon.

Best to review by commit

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5858 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 10/5/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `deps/not-react` --- ### 📝 Commits (9) - [`ff4027f`](https://github.com/actualbudget/actual/commit/ff4027ffebf51b697fcd1dda057ca063a69e7e61) patch/minor deps - [`cc3d8cd`](https://github.com/actualbudget/actual/commit/cc3d8cd5052d6da2fd8efeb2b3710beed580a286) @vitejs/plugin-basic-ssl 2.1.0 - [`00024a9`](https://github.com/actualbudget/actual/commit/00024a9a486fddc864a59fe02b6fcce83d498d72) remove chokidar - [`6e755a9`](https://github.com/actualbudget/actual/commit/6e755a98ced4bdc80daa2de4446b84eac1bbabcd) cross-env 10.1.0 - [`1ff9fc7`](https://github.com/actualbudget/actual/commit/1ff9fc713fca15a8288baaa0464da7fe95bb811d) downshift 9.0.10 - [`886c36e`](https://github.com/actualbudget/actual/commit/886c36ed36d33d9930b46900d17ba1c8e291954e) remove focus-visible - [`c054bec`](https://github.com/actualbudget/actual/commit/c054becc3b43f0715332032f07b9a3a585d7afa6) jsdom 27.0.0 - [`21a6f79`](https://github.com/actualbudget/actual/commit/21a6f794e0effa0b3cd8ab9c15a0e1c275e30dd4) rollup-plugin-visualizer 6.0.4 - [`e089e5c`](https://github.com/actualbudget/actual/commit/e089e5caa8570d3be3e78435484c58d38ad95245) note ### 📊 Changes **16 files changed** (+520 additions, -440 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e-test.yml` (+3 -3) 📝 `.github/workflows/update-vrt.yml` (+1 -1) 📝 `bin/run-vrt` (+1 -1) 📝 `package.json` (+1 -1) 📝 `packages/desktop-client/README.md` (+2 -2) 📝 `packages/desktop-client/index.html` (+0 -4) 📝 `packages/desktop-client/package.json` (+14 -16) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+108 -96) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx` (+22 -14) 📝 `packages/desktop-client/src/components/forms.tsx` (+1 -1) 📝 `packages/desktop-client/src/index.tsx` (+0 -3) 📝 `packages/desktop-client/vite.config.mts` (+1 -0) 📝 `packages/desktop-electron/package.json` (+2 -2) 📝 `packages/loot-core/package.json` (+4 -4) ➕ `upcoming-release-notes/5858.md` (+6 -0) 📝 `yarn.lock` (+354 -292) </details> ### 📄 Description Wow, this was a tough one 😅 Chosen to drop two dependencies: - chokidar was not used - focus-visible has been supported in all major browsers for a couple of years now, we don't need the polyfill anymore Code changes: - Drop focus-visible - Some downshift types changed, so there's some fiddling with getInputProps in Autocomplete - jsdom changing the selector library under the hood has messed with some tests - update playwright versions I couldn't get recharts v3 or inter-ui v4 to play ball, those will have to be seperate PRs when I get a chance. Hopefully I can get the react change working soon. Best to review by commit --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-19 08:48:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#83850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?