[Bug]: Syncing from GoCardless re-fills notes #790

New Issue

GiteaMirror · 2026-02-28T19:20:05-06:00

GiteaMirror commented

2026-02-28 19:20:05 -06:00

Originally created by @kymckay on GitHub (Dec 3, 2023).

Verified issue does not already exist?

I have searched and found no existing issue

What happened?

Link an account with GoCardless.
Sync your the transactions.
Set some note values to be an empty note.
Re-sync from GoCardless.

The notes get re-filled where they were manually edited to be empty. My expectation would be that the user input takes precedence (though I can infer why it is implemented in a way which fills the empty notes for simplicity).

I need to check the data model and the transaction import resolution logic, but if possible it'd be nice to only import notes to resolved transactions which still contain their imported note.

What error did you receive?

No response

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Originally created by @kymckay on GitHub (Dec 3, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? 1. Link an account with GoCardless. 2. Sync your the transactions. 3. Set some note values to be an empty note. 4. Re-sync from GoCardless. The notes get re-filled where they were manually edited to be empty. My expectation would be that the user input takes precedence (though I can infer why it is implemented in a way which fills the empty notes for simplicity). I need to check the data model and the transaction import resolution logic, but if possible it'd be nice to only import notes to resolved transactions which still contain their imported note. ### What error did you receive? _No response_ ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Firefox ### Operating System Linux

GiteaMirror added the bug label 2026-02-28 19:20:05 -06:00

GiteaMirror closed this issue

2026-02-28 19:20:06 -06:00

GiteaMirror commented

2026-02-28 19:20:06 -06:00

@MatissJanis commented on GitHub (Dec 30, 2023):

Tricky. Lets say you import a transaction that does not have notes. But a few days later you perform an import again, but this time there are notes. In this case you would expect the inverse: the empty notes to be replaced with the new notes.

@MatissJanis commented on GitHub (Dec 30, 2023): Tricky. Lets say you import a transaction that does not have notes. But a few days later you perform an import again, but this time there are notes. In this case you would expect the inverse: the empty notes to be replaced with the new notes.

GiteaMirror commented

2026-02-28 19:20:07 -06:00

@kymckay commented on GitHub (Dec 30, 2023):

@MatissJanis I think a good compromise solution to this is to not update reconciled transactions when doing transaction resolution. Avoids adding complexity to determine which empty notes have been set by the user, and still enables this kind of workflow where the user doesn't want the imported notes.

@kymckay commented on GitHub (Dec 30, 2023): @MatissJanis I think a good compromise solution to this is to not update reconciled transactions when doing transaction resolution. Avoids adding complexity to determine which empty notes have been set by the user, and still enables this kind of workflow where the user doesn't want the imported notes.

GiteaMirror commented

2026-02-28 19:20:07 -06:00

@MatissJanis commented on GitHub (Dec 30, 2023):

Makes sense. I've actually already created a patch for this here: https://github.com/actualbudget/actual/pull/2140

@MatissJanis commented on GitHub (Dec 30, 2023): Makes sense. I've actually already created a patch for this here: https://github.com/actualbudget/actual/pull/2140