github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6082] [MERGED] Sync cleared error #76296

New Issue
Closed
opened 2026-05-16 17:54:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 17:54:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6082
Author: @totallynotjon
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @matt-fidd

Base: master ← Head: sync_cleared_error

📝 Commits (6)

  • d28350e Adjusted calculation for cleared value when merging transactions, so that if the existing transaction specified cleared it will remain cleared.
  • 1ae8ef2 notes
  • c2eb1db coalesce to false and not null to satisfy the rabbit
  • e841ba9 Merge branch 'master' into sync_cleared_error
  • 40144a1 Update upcoming-release-notes/6082.md
  • a2e229c Merge branch 'master' into sync_cleared_error

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+1 -1)
➕ upcoming-release-notes/6082.md (+6 -0)

📄 Description

Fixes#5922 https://github.com/actualbudget/actual/issues/5922

Adjusted single line to change precedence for how the cleared field is reconciled upon importing in the sync process.

This assumes that if a user has an existing transaction as cleared, then during the merging process it should remain cleared regardless of the imported transaction.

Testing using OFX import and replicating the steps provided in the issue. After replicating I made this fix, rebuilt and tested again. This has the intended effect of leaving transactions which were manually cleared

This is my first PR so hopefully someone with more experience can come along and say if they would have any other suggestions.

The only situation I can imagine is if a user is manually UNclearing transactions that come in cleared. This would break that. However I don't see any way to quickly see if the cleared field is different than the value on original import. In an ideal world there would be something like a .userModified to identify if the value has been changed by the user either by rules or manually. To allow a more definitive reconciliation of synced/imported items.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6082 **Author:** [@totallynotjon](https://github.com/totallynotjon) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `sync_cleared_error` --- ### 📝 Commits (6) - [`d28350e`](https://github.com/actualbudget/actual/commit/d28350ee8c773d9e80f1a1cc216dd23b60703650) Adjusted calculation for cleared value when merging transactions, so that if the existing transaction specified cleared it will remain cleared. - [`1ae8ef2`](https://github.com/actualbudget/actual/commit/1ae8ef2c6a010bdb075840a575ad49d8ed6b30a3) notes - [`c2eb1db`](https://github.com/actualbudget/actual/commit/c2eb1dba4cc3c03ea25bad9330f470b101831c85) coalesce to false and not null to satisfy the rabbit - [`e841ba9`](https://github.com/actualbudget/actual/commit/e841ba954e736b70df927f340c8ec22056bf5109) Merge branch 'master' into sync_cleared_error - [`40144a1`](https://github.com/actualbudget/actual/commit/40144a1ca2143ef98d11400d57e072b6a45c8145) Update upcoming-release-notes/6082.md - [`a2e229c`](https://github.com/actualbudget/actual/commit/a2e229c49759a01c6bc02f1de31a53150a523fe4) Merge branch 'master' into sync_cleared_error ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+1 -1) ➕ `upcoming-release-notes/6082.md` (+6 -0) </details> ### 📄 Description Fixes#5922 https://github.com/actualbudget/actual/issues/5922 Adjusted single line to change precedence for how the cleared field is reconciled upon importing in the sync process. This assumes that if a user has an existing transaction as cleared, then during the merging process it should remain cleared regardless of the imported transaction. Testing using OFX import and replicating the steps provided in the issue. After replicating I made this fix, rebuilt and tested again. This has the intended effect of leaving transactions which were manually cleared This is my first PR so hopefully someone with more experience can come along and say if they would have any other suggestions. The only situation I can imagine is if a user is manually UNclearing transactions that come in cleared. This would break that. However I don't see any way to quickly see if the cleared field is different than the value on original import. In an ideal world there would be something like a .userModified to identify if the value has been changed by the user either by rules or manually. To allow a more definitive reconciliation of synced/imported items. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 17:54:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#76296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?