github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1812] [Bug]: Gocardless import adds declined transactions #7621

New Issue
Closed
opened 2026-04-10 17:31:11 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-04-10 17:31:11 -05:00
Owner
Copy Link

Originally created by @benjylxwang on GitHub (Oct 17, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1812

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

If there are declined bank transactions within the bank import window through GoCardless (I'm using Starling UK), they get added to the list of transactions against the linked account. This happens every time you run the import/sync, so every time I sync the account I need to delete the declined transactions or my budget account balance is out of sync with the bank account balance

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox, Chrome

Operating System

Windows 11

Originally created by @benjylxwang on GitHub (Oct 17, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1812 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? If there are declined bank transactions within the bank import window through GoCardless (I'm using Starling UK), they get added to the list of transactions against the linked account. This happens every time you run the import/sync, so every time I sync the account I need to delete the declined transactions or my budget account balance is out of sync with the bank account balance ### What error did you receive? _No response_ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox, Chrome ### Operating System Windows 11
GiteaMirror added the bug label 2026-04-10 17:31:11 -05:00
GiteaMirror commented 2026-04-10 17:31:13 -05:00
Author
Owner
Copy Link

@benjylxwang commented on GitHub (Oct 17, 2023):

Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the downloadGoCardlessTransactions so that it doesn't return any of the declined ones?

That's here in the codebase.

Only thing I'm not sure about is if that information is in the transaction object at this stage - haven't had a chance to test. The other place I could see it working would be in reconcileGoCardlessTransactions in the same sync.ts file.

<!-- gh-comment-id:1767206553 --> @benjylxwang commented on GitHub (Oct 17, 2023): Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the `downloadGoCardlessTransactions` so that it doesn't return any of the declined ones? That's [here](https://github.com/actualbudget/actual/blob/acf44560778fc0202baad538ef7210f81121e476/packages/loot-core/src/server/accounts/sync.ts#L211) in the codebase. Only thing I'm not sure about is if that information is in the transaction object at this stage - haven't had a chance to test. The other place I could see it working would be in `reconcileGoCardlessTransactions` in the same `sync.ts` file.
GiteaMirror commented 2026-04-10 17:31:13 -05:00
Author
Owner
Copy Link

@kyrias commented on GitHub (Oct 17, 2023):

Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the downloadGoCardlessTransactions so that it doesn't return any of the declined ones?

If done then this should be done in a bank integration in the sync server. https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless/banks

But if the transaction was declined then it should not be served at all and so if anything you should report this as an issue to GoCardless.

<!-- gh-comment-id:1767215611 --> @kyrias commented on GitHub (Oct 17, 2023): > Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the `downloadGoCardlessTransactions` so that it doesn't return any of the declined ones? If done then this should be done in a bank integration in the sync server. https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless/banks But if the transaction was declined then it should not be served at all and so if anything you should report this as an issue to GoCardless.
GiteaMirror commented 2026-04-10 17:31:14 -05:00
Author
Owner
Copy Link

@benjylxwang commented on GitHub (Oct 17, 2023):

Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the downloadGoCardlessTransactions so that it doesn't return any of the declined ones?

If done then this should be done in a bank integration in the sync server. https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless/banks

But if the transaction was declined then it should not be served at all and so if anything you should report this as an issue to GoCardless.

Ah ok thanks for the clarification on that. I'll report it to GoCardless.

<!-- gh-comment-id:1767228191 --> @benjylxwang commented on GitHub (Oct 17, 2023): > > Had a quick look through the code and maybe we could just add a filter on the transactions that come back from the `downloadGoCardlessTransactions` so that it doesn't return any of the declined ones? > > If done then this should be done in a bank integration in the sync server. https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless/banks > > But if the transaction was declined then it should not be served at all and so if anything you should report this as an issue to GoCardless. Ah ok thanks for the clarification on that. I'll report it to GoCardless.
GiteaMirror commented 2026-04-10 17:31:14 -05:00
Author
Owner
Copy Link

@ACWalker commented on GitHub (Jul 24, 2024):

I've just come across this issue myself with Starling too. I have raised a support issue to GoCardless so will see what they say. Otherwise I will make a bank integration for Starling as @kyrias mentioned.

<!-- gh-comment-id:2248378233 --> @ACWalker commented on GitHub (Jul 24, 2024): I've just come across this issue myself with Starling too. I have raised a support issue to GoCardless so will see what they say. Otherwise I will make a bank integration for Starling as @kyrias mentioned.
GiteaMirror commented 2026-04-10 17:31:14 -05:00
Author
Owner
Copy Link

@ACWalker commented on GitHub (Jul 26, 2024):

I got a response from gocardless, they said:

I have found the transactions in the our response.  We will look into it to see what might bet the cause why these are returning as "Pending".  I will get back to you as soon as we have any news on the matter.

Will see what they find

<!-- gh-comment-id:2252255789 --> @ACWalker commented on GitHub (Jul 26, 2024): I got a response from gocardless, they said: ``` I have found the transactions in the our response.  We will look into it to see what might bet the cause why these are returning as "Pending".  I will get back to you as soon as we have any news on the matter. ``` Will see what they find
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?