github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5875] [CLOSED] [WIP] Implement PayeeAutocomplete2 based on react-aria-component's ComboBox #76166

New Issue
Closed
opened 2026-05-16 17:46:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 17:46:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5875
Author: @joel-jeremy
Created: 10/6/2025
Status: ❌ Closed

Base: master ← Head: PayeeAutocomplete2

📝 Commits (9)

  • 4be04b9 Implement PayeeAutocomplete2 based on react-aria-component's ComboBox
  • 3f21762 Cleanup
  • c883b38 Fix lint and typecheck errors
  • 2392cb9 Fix typecheck error
  • b9f01fa Update schedule test
  • 4e9014a yarn install
  • f9d6f28 [autofix.ci] apply automated fixes
  • 6d33017 Rename to ComboBox
  • c22f3cc [autofix.ci] apply automated fixes

📊 Changes

9 files changed (+631 additions, -42 deletions)

View changed files

📝 packages/component-library/package.json (+1 -0)
➕ packages/component-library/src/ComboBox.tsx (+198 -0)
➕ packages/desktop-client/e2e/page-models/schedule-edit-modal.ts (+60 -0)
📝 packages/desktop-client/e2e/page-models/schedules-page.ts (+8 -35)
📝 packages/desktop-client/e2e/schedules.test.ts (+11 -7)
➕ packages/desktop-client/src/components/autocomplete/PayeeComboBox.tsx (+331 -0)
📝 packages/desktop-client/src/components/rules/RuleEditor.tsx (+8 -0)
📝 packages/loot-core/src/shared/normalisation.ts (+8 -0)
➕ upcoming-release-notes/5875.md (+6 -0)

📄 Description

An attempt to replace the current autocomplete that is currently used by Actual (based on Downshift). The best case is we can have feature parity with the current autocomplete but even if not, I think the migration to a more manageable autocomplete implementation would be a big win for the maintainability of the project.

For this PR, the new component is only applied on the rules edit page:
image

This doesn't have the Make transfer and Manage payees footer buttons yet

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5875 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 10/6/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `PayeeAutocomplete2` --- ### 📝 Commits (9) - [`4be04b9`](https://github.com/actualbudget/actual/commit/4be04b905eb099e428a755db3762a02d72c2faa6) Implement PayeeAutocomplete2 based on react-aria-component's ComboBox - [`3f21762`](https://github.com/actualbudget/actual/commit/3f2176208c4c7e6200a931a063d0137559dfd971) Cleanup - [`c883b38`](https://github.com/actualbudget/actual/commit/c883b38a3922b4366808d1dc7ca2dcfc94fc95a7) Fix lint and typecheck errors - [`2392cb9`](https://github.com/actualbudget/actual/commit/2392cb97e1344a8313865a7d9275446c21af2583) Fix typecheck error - [`b9f01fa`](https://github.com/actualbudget/actual/commit/b9f01fa219d1b296c3f781239b3a0d3b63e48409) Update schedule test - [`4e9014a`](https://github.com/actualbudget/actual/commit/4e9014adeea1facaeb6cc32f75ba9ead91c06e0f) yarn install - [`f9d6f28`](https://github.com/actualbudget/actual/commit/f9d6f2826408bd6620756c11cb86f755929a358e) [autofix.ci] apply automated fixes - [`6d33017`](https://github.com/actualbudget/actual/commit/6d330172e2315b1aeba464ee99d7ccdb2137b58c) Rename to ComboBox - [`c22f3cc`](https://github.com/actualbudget/actual/commit/c22f3cc5be718796ad518075af18706d706a8995) [autofix.ci] apply automated fixes ### 📊 Changes **9 files changed** (+631 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/package.json` (+1 -0) ➕ `packages/component-library/src/ComboBox.tsx` (+198 -0) ➕ `packages/desktop-client/e2e/page-models/schedule-edit-modal.ts` (+60 -0) 📝 `packages/desktop-client/e2e/page-models/schedules-page.ts` (+8 -35) 📝 `packages/desktop-client/e2e/schedules.test.ts` (+11 -7) ➕ `packages/desktop-client/src/components/autocomplete/PayeeComboBox.tsx` (+331 -0) 📝 `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+8 -0) 📝 `packages/loot-core/src/shared/normalisation.ts` (+8 -0) ➕ `upcoming-release-notes/5875.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> An attempt to replace the current autocomplete that is currently used by Actual (based on Downshift). The best case is we can have feature parity with the current autocomplete but even if not, I think the migration to a more manageable autocomplete implementation would be a big win for the maintainability of the project. For this PR, the new component is only applied on the rules edit page: <img width="1881" height="1327" alt="image" src="https://github.com/user-attachments/assets/8869a4c9-5807-4f5e-8172-5fe274eeb6ea" /> This doesn't have the Make transfer and Manage payees footer buttons yet --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 17:46:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#76166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?