github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4493] [MERGED] Fixed transaction dates in bank sync with MBANK_RETAIL_BREXPLPW #75401

New Issue
Closed
opened 2026-05-16 16:50:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 16:50:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4493
Author: @szymon-romanko
Created: 3/1/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @matt-fidd

Base: master ← Head: mbank_api

📝 Commits (9)

  • 9251d3e fixed transaction date for MBANK_RETAIL_BREXPLPW
  • 3270505 cleared up imports after previous commit (9251d3e1)
  • c75ceba added release notes
  • f4b090a linted code
  • 4b506ee Merge branch 'master' into mbank_api
  • 4b18ec4 Merge branch 'master' into mbank_api
  • b1ecbf6 Merge branch 'master' into mbank_api
  • 648c09c Update packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js
  • 3853cd8 Merge branch 'master' into mbank_api

📊 Changes

2 files changed (+28 additions, -0 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js (+22 -0)
➕ upcoming-release-notes/4493.md (+6 -0)

📄 Description

I've noticed while syncing with mBank Retail Poland (mbank_retail_brexplpw), that bookingDate and valueDate are swapped in their API.
When inspecting API response from gocardless, bookingDate would always come after valueDate, so I fixed it per bank by overwriting normalizeTransaction method in packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4493 **Author:** [@szymon-romanko](https://github.com/szymon-romanko) **Created:** 3/1/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `mbank_api` --- ### 📝 Commits (9) - [`9251d3e`](https://github.com/actualbudget/actual/commit/9251d3e1552eae905085276bd67ff2b3872da573) fixed transaction date for MBANK_RETAIL_BREXPLPW - [`3270505`](https://github.com/actualbudget/actual/commit/32705057eaa10e0a0d5f816807d3bf0eb8ec082e) cleared up imports after previous commit (9251d3e1) - [`c75ceba`](https://github.com/actualbudget/actual/commit/c75ceba8764b97bc7aa746d710e2d10d992401d5) added release notes - [`f4b090a`](https://github.com/actualbudget/actual/commit/f4b090a08c770ac0f1a2463e76826ae3bbbafbab) linted code - [`4b506ee`](https://github.com/actualbudget/actual/commit/4b506eec137563c3f1f115721adb3d5436bd6713) Merge branch 'master' into mbank_api - [`4b18ec4`](https://github.com/actualbudget/actual/commit/4b18ec41fc1a8cde802dba841a5ca038404541a0) Merge branch 'master' into mbank_api - [`b1ecbf6`](https://github.com/actualbudget/actual/commit/b1ecbf677d7af7668fa578d7aeb00d64214b6f9a) Merge branch 'master' into mbank_api - [`648c09c`](https://github.com/actualbudget/actual/commit/648c09c364fa1d94afee1f2b1bfeae2f551899fd) Update packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js - [`3853cd8`](https://github.com/actualbudget/actual/commit/3853cd8e5395b13c33094b897276733caf4a01e5) Merge branch 'master' into mbank_api ### 📊 Changes **2 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js` (+22 -0) ➕ `upcoming-release-notes/4493.md` (+6 -0) </details> ### 📄 Description I've noticed while syncing with mBank Retail Poland (`mbank_retail_brexplpw`), that `bookingDate` and `valueDate` are swapped in their API. When inspecting API response from gocardless, `bookingDate` would always come after `valueDate`, so I fixed it per bank by overwriting `normalizeTransaction` method in `packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 16:50:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#75401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?