github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1399] [Bug]: Simple Goal Templates compound when overwritting #7467

New Issue
Closed
opened 2026-04-10 17:19:08 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-10 17:19:08 -05:00
Owner
Copy Link

Originally created by @youngcw on GitHub (Jul 26, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1399

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

It looks like the speed upgrade with the setZero change has made it so the simple template (#template 10) will compound when using the overwrite option instead of resetting to zero and then applying. If I add an await to the setZero call it works as expected, but I imagine that loses most of the speed gains. I haven't looked into if the math could be changed to overcome this.

What error did you receive?

No response

Where are you hosting Actual?

NAS

What browsers are you seeing the problem on?

Chrome

Operating System

Linux

Originally created by @youngcw on GitHub (Jul 26, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1399 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? It looks like the speed upgrade with the setZero change has made it so the simple template (`#template 10`) will compound when using the overwrite option instead of resetting to zero and then applying. If I add an await to the setZero call it works as expected, but I imagine that loses most of the speed gains. I haven't looked into if the math could be changed to overcome this. ### What error did you receive? _No response_ ### Where are you hosting Actual? NAS ### What browsers are you seeing the problem on? Chrome ### Operating System Linux
GiteaMirror added the buggoal templates labels 2026-04-10 17:19:08 -05:00
GiteaMirror commented 2026-04-10 17:19:10 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Jul 26, 2023):

Good catch! The 'await setZero' is included in PR #1350. It was missed in the earlier PR. When I was testing it, everything was calculated as expected in all of the various scenarios I tried and we keep the speed gains! If #1350 is accepted, this will be resolved.

<!-- gh-comment-id:1652621716 --> @shall0pass commented on GitHub (Jul 26, 2023): Good catch! The 'await setZero' is included in PR #1350. It was missed in the earlier PR. When I was testing it, everything was calculated as expected in all of the various scenarios I tried and we keep the speed gains! If #1350 is accepted, this will be resolved.
GiteaMirror commented 2026-04-10 17:19:10 -05:00
Author
Owner
Copy Link

@kyrias commented on GitHub (Jul 26, 2023):

Might make sense to extract that change to a separate PR that might hopefully get reviewed and merged a bit quicker. :)

<!-- gh-comment-id:1652625133 --> @kyrias commented on GitHub (Jul 26, 2023): Might make sense to extract that change to a separate PR that might hopefully get reviewed and merged a bit quicker. :)
GiteaMirror commented 2026-04-10 17:19:11 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jul 26, 2023):

hopefully get reviewed and merged a bit quicker

or we could just pester Jed to merge 1350 :)

<!-- gh-comment-id:1652637952 --> @youngcw commented on GitHub (Jul 26, 2023): > hopefully get reviewed and merged a bit quicker or we could just pester Jed to merge 1350 :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug goal templates
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?