github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1275] [Tech Debt] Refactor "Select" component usage to "CustomSelect" #7417

New Issue
Closed
opened 2026-04-10 17:14:35 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-10 17:14:35 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Jul 4, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1275

We currently have 2x Select components - Select & CustomSelect.

The goal would be to remove the Select component in favor of CustomSelect/Autocomplete.

This would make all the select-s in the app have a consistent UI and UX.

Originally created by @MatissJanis on GitHub (Jul 4, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1275 We currently have 2x Select components - Select & CustomSelect. The goal would be to remove the Select component in favor of CustomSelect/Autocomplete. This would make all the select-s in the app have a consistent UI and UX.
GiteaMirror added the good first issuetech debt labels 2026-04-10 17:14:35 -05:00
GiteaMirror commented 2026-04-10 17:14:38 -05:00
Author
Owner
Copy Link

@biohzrddd commented on GitHub (Jul 4, 2023):

Agreed we need just one. The CustomSelect component from the reach package is quite a pain to style (e.g. I can't figure out how to get rid of the blue flashes in #922) and doesn't offer much that I can see over the built-in Select. Can we not style the built-in good enough?

<!-- gh-comment-id:1619754397 --> @biohzrddd commented on GitHub (Jul 4, 2023): Agreed we need just one. The CustomSelect component from the reach package is quite a pain to style (e.g. I can't figure out how to get rid of the blue flashes in #922) and doesn't offer much that I can see over the built-in Select. Can we not style the built-in good enough?
GiteaMirror commented 2026-04-10 17:14:39 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Jul 9, 2023):

Still one more:

927c859456/packages/desktop-client/src/components/modals/ConfirmCategoryDelete.js (L80-L99)

927c859456/packages/desktop-client/src/components/autocomplete/CategorySelect.tsx (L22-L44)

<!-- gh-comment-id:1627802540 --> @j-f1 commented on GitHub (Jul 9, 2023): Still one more: https://github.com/actualbudget/actual/blob/927c859456475b98611c9078a4657dcaacc156a5/packages/desktop-client/src/components/modals/ConfirmCategoryDelete.js#L80-L99 https://github.com/actualbudget/actual/blob/927c859456475b98611c9078a4657dcaacc156a5/packages/desktop-client/src/components/autocomplete/CategorySelect.tsx#L22-L44
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label good first issue tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?