github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1264] Migrate all URL-based modals (usePushModal) to the state-based system (dispatch(pushModal(...))) #7413

New Issue
Closed
opened 2026-04-10 17:14:17 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-10 17:14:17 -05:00
Owner
Copy Link

Originally created by @j-f1 on GitHub (Jul 2, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1264

Many modals currently use the dispatch(pushModal()) / actions.pushModal system instead of the (presumably?) newer router-based usePushModal system. When touching these modals, we should migrate them to the new system.

Originally created by @j-f1 on GitHub (Jul 2, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1264 Many modals currently use the `dispatch(pushModal())` / `actions.pushModal` system instead of the (presumably?) newer router-based `usePushModal` system. When touching these modals, we should migrate them to the new system.
GiteaMirror added the tech debt label 2026-04-10 17:14:17 -05:00
GiteaMirror commented 2026-04-10 17:14:19 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Jul 3, 2023):

Thinking about this again, I think we should go the other way — usePushModal modals are weird because they affect the URL which messes up a bunch of subtle things in the app (including the way they take up the whole page if you refresh while one is open).

<!-- gh-comment-id:1617017448 --> @j-f1 commented on GitHub (Jul 3, 2023): Thinking about this again, I think we should go the other way — `usePushModal` modals are weird because they affect the URL which messes up a bunch of subtle things in the app (including the way they take up the whole page if you refresh while one is open).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?