[Bug]: Cant change amount sign from negative in schedule on firefox #740

Closed
opened 2026-02-28 19:17:07 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @youngcw on GitHub (Nov 17, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When setting up or editing a schedule in firefox the amount cant be changed to positive. It works fine in Chrome browsers. If you click it, nothing happens when it should change between '-' and '+'.

What error did you receive?

no error, it just doesn't work

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

Firefox

Operating System

None

Originally created by @youngcw on GitHub (Nov 17, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? When setting up or editing a schedule in firefox the amount cant be changed to positive. It works fine in Chrome browsers. If you click it, nothing happens when it should change between '-' and '+'. ### What error did you receive? no error, it just doesn't work ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? Firefox ### Operating System None
GiteaMirror added the bug label 2026-02-28 19:17:07 -06:00
Author
Owner

@miqh commented on GitHub (Nov 18, 2023):

Here's a snippet of interest:

93922567fc/packages/desktop-client/src/components/util/AmountInput.js (L71)

Firefox is (correctly, IMO) respecting the disabled state of the sign toggling button.

On the other hand, Chromium appears to trigger the pointer-related event handlers irrespective of disabled.

focused is also a prop to the AmountInput and it's never changed.

When the sign toggle button is forcefully enabled, interaction looks like this:

1

I'm unsure what the best intervention here is, especially since EditSchedule doesn't appear to maintain a focused state.

@miqh commented on GitHub (Nov 18, 2023): Here's a snippet of interest: https://github.com/actualbudget/actual/blob/93922567fc5ec3952e60203a04a2cb7c1821fe70/packages/desktop-client/src/components/util/AmountInput.js#L71 Firefox is (correctly, IMO) respecting the `disabled` state of the sign toggling button. On the other hand, Chromium appears to trigger the pointer-related event handlers irrespective of `disabled`. `focused` is also a prop to the `AmountInput` and it's never changed. When the sign toggle button is forcefully enabled, interaction looks like this: ![1](https://github.com/actualbudget/actual/assets/43751307/f26cab62-0139-481e-8987-1b0509af85d7) I'm unsure what the best intervention here is, especially since `EditSchedule` doesn't appear to maintain a `focused` state.
Author
Owner

@bakoff44 commented on GitHub (Nov 29, 2023):

I have the same problem too, on Firefox 120.0 (64-bit).

Also, typing "+123" in the field makes the app totally crashing, with the single following line of log :

k@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62089 C@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62338 w@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19632 5291/S/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19764 v@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:105362 i2@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:64289 aQ@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:76085 sF@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:118360 sD@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113204 sj@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113132 sE@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:112984 sp@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:109296 sy@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:110118 oI@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:47882 33936/sf/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:107617

My docker container did not returned any errors.

@bakoff44 commented on GitHub (Nov 29, 2023): I have the same problem too, on Firefox 120.0 (64-bit). Also, typing "+123" in the field makes the app totally crashing, with the single following line of log : ``` k@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62089 C@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62338 w@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19632 5291/S/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19764 v@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:105362 i2@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:64289 aQ@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:76085 sF@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:118360 sD@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113204 sj@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113132 sE@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:112984 sp@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:109296 sy@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:110118 oI@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:47882 33936/sf/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:107617 ``` My docker container did not returned any errors.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#740