github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #916] [MERGED] ♻️ (autocomplete) refactor old autocomplete to remove lively dep #73389

New Issue
Closed
opened 2026-05-16 14:30:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-16 14:30:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/916
Author: @MatissJanis
Created: 4/16/2023
Status: ✅ Merged
Merged: 4/19/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/old-autocomplete

📝 Commits (5)

  • b61b499 ♻️ (autocomplete) refactor old autocomplete to remove lively dep
  • 1d16252 Release notes
  • 02f3d2c Some fixes
  • 285dbc8 Fixes
  • fca7194 Merge branch 'master' into matiss/old-autocomplete

📊 Changes

5 files changed (+52 additions, -51 deletions)

View changed files

📝 packages/desktop-client/package.json (+0 -1)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.js (+45 -39)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -1)
➕ upcoming-release-notes/916.md (+6 -0)
📝 yarn.lock (+0 -10)

📄 Description

So the new autocomplete is not able to fulfil all our needs. I invested a lot of my time in trying to make react-select work here, but clearly it's not cut out to be that great. So lets not invest any more time in trying to hack it.. we can call this experiment as failed and move on.

Anyways, this PR reverts back to the old autocomplete AND refactors it slightly so it would not use lively anymore.

These are the next steps I'm planing to take after merging this PR:

  1. Remove all "new autocomplete" code
  2. Close off "new autocomplete" tickets (issues)
  3. Work on further refactors of the old autocomplete (I really dislike how we currently manage state here with the updater and whatnot.. those are just temp. hacks)
  4. (maybe) work on upgrading Downshift

Let me know what you think!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/916 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/16/2023 **Status:** ✅ Merged **Merged:** 4/19/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/old-autocomplete` --- ### 📝 Commits (5) - [`b61b499`](https://github.com/actualbudget/actual/commit/b61b499dee2ca03dde2576ae65f38de06753e03e) :recycle: (autocomplete) refactor old autocomplete to remove lively dep - [`1d16252`](https://github.com/actualbudget/actual/commit/1d1625299a732209af6bd788351cf2cafa17f5aa) Release notes - [`02f3d2c`](https://github.com/actualbudget/actual/commit/02f3d2cceb9f9eb38426bca6231fe7f0fa46e07b) Some fixes - [`285dbc8`](https://github.com/actualbudget/actual/commit/285dbc8c269e05ff91783bb9d94f8be2d263a278) Fixes - [`fca7194`](https://github.com/actualbudget/actual/commit/fca7194b42490fa38ba3ade0ffca6c425a5609bc) Merge branch 'master' into matiss/old-autocomplete ### 📊 Changes **5 files changed** (+52 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+0 -1) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.js` (+45 -39) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -1) ➕ `upcoming-release-notes/916.md` (+6 -0) 📝 `yarn.lock` (+0 -10) </details> ### 📄 Description So the new autocomplete is not able to fulfil all our needs. I invested a lot of my time in trying to make `react-select` work here, but clearly it's not cut out to be that great. So lets not invest any more time in trying to hack it.. we can call this experiment as failed and move on. Anyways, this PR reverts back to the old autocomplete AND refactors it slightly so it would not use `lively` anymore. These are the next steps I'm planing to take after merging this PR: 1. Remove all "new autocomplete" code 2. Close off "new autocomplete" tickets (issues) 3. Work on further refactors of the old autocomplete (I really dislike how we currently manage state here with the `updater` and whatnot.. those are just temp. hacks) 4. (maybe) work on upgrading `Downshift` Let me know what you think! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-16 14:30:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#73389