github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1014] [Bug]: Creating a new payee doesn't change focus #7334

New Issue
Closed
opened 2026-04-10 17:06:57 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-10 17:06:57 -05:00
Owner
Copy Link

Originally created by @rich-howell on GitHub (May 8, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1014

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When adding a new Payee from the drop down - if you select "Create Payee"

image

The focus doesn't change out of the Payee drop down it just stays there.

image

What error did you receive?

None

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

Originally created by @rich-howell on GitHub (May 8, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1014 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? When adding a new Payee from the drop down - if you select "Create Payee" ![image](https://user-images.githubusercontent.com/22135084/236895695-b07f7433-161a-47a9-967d-875320e8acca.png) The focus doesn't change out of the Payee drop down it just stays there. ![image](https://user-images.githubusercontent.com/22135084/236895896-eb1b25ec-0947-4c7a-bb48-3098ac36b391.png) ### What error did you receive? None ### Where are you hosting Actual? Fly.io ### What browsers are you seeing the problem on? Microsoft Edge ### Operating System Windows 11
GiteaMirror added the bug label 2026-04-10 17:06:57 -05:00
GiteaMirror commented 2026-04-10 17:06:59 -05:00
Author
Owner
Copy Link

@trevdor commented on GitHub (May 17, 2023):

imo, both this and #941 describe Autocomplete component and/or transaction input workflow enhancements, not bugs. As such, we should route them through the ideas process.

That is, the focus stays in the input when you make any selection in our autocomplete dropdown component (Payee and Category being two examples). And <tab> is simply not a key our component is configured to use for choosing an option*. From what I can find, some accessibility guidance suggests supporting it, some doesn't.

@MatissJanis did some cleanup in our Autocomplete component--would be curious how he's leaning today re: building or pulling an autocomplete off-the-shelf that might support these features already.

*Autocomplete does have a "loose mode" where it chooses an item on <tab>. Doesn't appear used yet--the whole app uses isStrict. Might be no biggie to turn off isStrict, might have other implications. I haven't traced its use far enough to know.

<!-- gh-comment-id:1550718893 --> @trevdor commented on GitHub (May 17, 2023): imo, both this and #941 describe `Autocomplete` component and/or transaction input workflow enhancements, not bugs. As such, we should route them through the ideas process. That is, the focus stays in the input when you make _any_ selection in our autocomplete dropdown component (Payee and Category being two examples). And `<tab>` is simply not a key our component is configured to use for choosing an option*. From what I can find, some accessibility guidance suggests supporting it, some doesn't. @MatissJanis did some cleanup in our `Autocomplete` component--would be curious how he's leaning today re: building or pulling an autocomplete off-the-shelf that might support these features already. \*Autocomplete _does_ have a "loose mode" where it chooses an item on `<tab>`. Doesn't appear used yet--the whole app uses `isStrict`. Might be no biggie to turn off `isStrict`, might have other implications. I haven't traced its use far enough to know.
GiteaMirror commented 2026-04-10 17:06:59 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (May 20, 2023):

@MatissJanis did some cleanup in our Autocomplete component--would be curious how he's leaning today re: building or pulling an autocomplete off-the-shelf that might support these features already.

Exptending our existing autocomplete for sure. I tried porting it to an off-the-shelf solution, but there's just too many weird quirks we need to support in order not to break existing workflows. I couldn't solve them all nicely, so autocomplete-v2 was removed and I just upgraded the existing solution from Class component to a Function (+upgraded dependencies).

<!-- gh-comment-id:1555914890 --> @MatissJanis commented on GitHub (May 20, 2023): > @MatissJanis did some cleanup in our Autocomplete component--would be curious how he's leaning today re: building or pulling an autocomplete off-the-shelf that might support these features already. Exptending our existing autocomplete for sure. I tried porting it to an off-the-shelf solution, but there's just too many weird quirks we need to support in order not to break existing workflows. I couldn't solve them all nicely, so autocomplete-v2 was removed and I just upgraded the existing solution from Class component to a Function (+upgraded dependencies).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?