mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-13 13:43:35 -05:00
[GH-ISSUE #944] [Bug]: Accounts, adding account and changing type resets off budget #7309
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#7309
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rich-howell on GitHub (Apr 23, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/944
Verified issue does not already exist?
What happened?
When changing an account type on the add account dialog, the off budget checkbox is reset to an unchecked state.
What error did you receive?
None
Where are you hosting Actual?
Fly.io
What browsers are you seeing the problem on?
Microsoft Edge
Operating System
Windows 11
@j-f1 commented on GitHub (Apr 23, 2023):
I believe this is expected since the account type defines whether it should be on/off budget by default. That said, I don’t think there is much value in having the different account types so maybe we can just remove the dropdown?
@rich-howell commented on GitHub (Apr 23, 2023):
In my head I created an account, went through the motions, clicked the off budget checkbox then thought, "Ah this should be savings" changed it and pressed add. It ended up On Budget
As I was in auto pilot I didn't notice the checked change state.
Removing the drop down works if it doesn't create any other functional implications, is that data used in reporting etc?
@j-f1 commented on GitHub (Apr 23, 2023):
I checked pretty thoroughly and it seems to only be displayed on the mobile account list and nowheere else
@MatissJanis commented on GitHub (Apr 23, 2023):
I don't think removing account type entirely is the way to go here. Right now splitting between on/off budget is a very handy feature to distinguish between accounts that need to be considered in the budget and "other accounts" (i.e. investments, savings, loans, etc.). In the future I can see even more distinctions between the various types, so I do think we should keep around the account
typefield.@j-f1 commented on GitHub (Apr 23, 2023):
I think if we do want to expand this, it would be good to start with a clean slate and think carefully about exactly which categories we want to have. Additionally, we should not use the
typekey because it is basically impossible to code search for.@MatissJanis commented on GitHub (May 17, 2023):
Ok, I have changed my mind about this. Lets kill the
typefield.offbudget/onbudgetis sufficient.@rich-howell commented on GitHub (May 18, 2023):
Are you sure? What happens in the future if/when we wanted to do some other bits with Credit Cards? How would that work?
@MatissJanis commented on GitHub (May 20, 2023):
So right now the account type field is unused (as in: you set it when creating an account, but then it's not used anywhere else). For the sake of simplicity of the product - I think it makes sense to cut it.
AND: if in the future we want to build some special functionality for account-types - we can then bring it back. But even then - maybe it won't be
account_type, but rather a toggle. Similar as we currently have with on-budget/off-budget.