github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #7671] [Bug]: Titlebar server sync icon not centred #72895

New Issue
Closed
opened 2026-05-16 13:49:04 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-05-16 13:49:04 -05:00
Owner
Copy Link

Originally created by @tjmills-dev on GitHub (May 1, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7671

What happened?

The server sync icon in the titlebar is not centred in its div, unlike the eye icon:

Image

This results from an empty span with a 3px left margin.

Image

The offending line can be found at 1afe7c9a1e/packages/desktop-client/src/components/Titlebar.tsx (L246) - I'm not sure why the margin is added as the flexbox takes care of the spacing, so might be that it can just be removed?

How can we reproduce the issue?

  1. Go to any page on the web client that has server syncing
  2. Hover over the sync icon
  3. Notice that the icon is not quite centred to its shaded background
  4. Be unable to unnotice this

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Originally created by @tjmills-dev on GitHub (May 1, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/7671 ### What happened? The server sync icon in the titlebar is not centred in its div, unlike the eye icon: <img width="154" height="117" alt="Image" src="https://github.com/user-attachments/assets/f09d4cb5-227e-4311-9d31-851e80639f14" /> This results from an empty span with a 3px left margin. <img width="426" height="157" alt="Image" src="https://github.com/user-attachments/assets/6a628835-3b15-4b82-a75f-719d7bb48ae0" /> The offending line can be found at https://github.com/actualbudget/actual/blob/1afe7c9a1e55fb76e3663f14edfd6dd6db56e4bc/packages/desktop-client/src/components/Titlebar.tsx#L246 - I'm not sure why the margin is added as the flexbox takes care of the spacing, so might be that it can just be removed? ### How can we reproduce the issue? 1. Go to any page on the web client that has server syncing 2. Hover over the sync icon 3. Notice that the icon is not quite centred to its shaded background 4. Be unable to unnotice this ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Linux
GiteaMirror added the bug label 2026-05-16 13:49:04 -05:00
GiteaMirror commented 2026-05-16 13:49:05 -05:00
Author
Owner
Copy Link

@Juulz commented on GitHub (May 1, 2026):

The text is null unless it is 'Disabled', so it may not be empty. I suppose the text styling could be in the syncState === 'disabled' block.

I will fix this. Thanks for the catch!

<!-- gh-comment-id:4359451323 --> @Juulz commented on GitHub (May 1, 2026): The text is null unless it is 'Disabled', so it may not be empty. I suppose the text styling could be in the `syncState === 'disabled'` block. I will fix this. Thanks for the catch!
GiteaMirror commented 2026-05-16 13:49:06 -05:00
Author
Owner
Copy Link

@tjmills-dev commented on GitHub (May 1, 2026):

Ah yes I see now. Thanks for the fix!

<!-- gh-comment-id:4362113770 --> @tjmills-dev commented on GitHub (May 1, 2026): Ah yes I see now. Thanks for the fix!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#72895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?