mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[GH-ISSUE #90] Replace currency-formatter with Intl.NumberFormat to reduce dependencies
#69839
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#69839
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TomAFrench on GitHub (Jun 15, 2022).
Original GitHub issue: https://github.com/actualbudget/actual/issues/90
We've currently got a dependency on a fork of
currency-formatterwhich in turn depends on a fork ofaccounting.js(both maintained by jlongster). This is only used twice in the entire codebase.b4696ce598/packages/loot-core/src/shared/util.js (L289-L294)b4696ce598/packages/loot-core/src/shared/util.js (L322-L324)As mentioned in the comment if we switch to use Intl.NumberFormat then we can ditch these dependencies as they're not particularly necessary. Intl is well supported in the main mobile browsers now.
@trevdor commented on GitHub (Jun 17, 2022):
@TomAFrench Have you done this work yet?
@trevdor commented on GitHub (Jun 17, 2022):
Ooh, that could sound like, "Why don't you hurry up and do it!?!" I meant, I have formatting working with
Int.NumberFormaton a branch of mine, and can open a PR if I won't be stepping on your work already completed.@TomAFrench commented on GitHub (Jun 17, 2022):
Nope, I was planning on tackling it this weekend. If you've got a branch ready then feel free to make a PR, I'd be happy to take a look and give feedback.
@trevdor commented on GitHub (Jun 17, 2022):
Would love feedback. Just linked ☝🏻