github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-13 17:43:23 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6641] [MERGED] Fix missing final newline in generated release notes #69012

New Issue
Closed
opened 2026-05-14 03:41:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-14 03:41:42 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6641
Author: @Copilot
Created: 1/13/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @MatissJanis

Base: master ← Head: copilot/fix-release-notes-lint-warnings

📝 Commits (3)

  • c150e62 Initial plan
  • 57522f0 Add release notes for PR #6641
  • 2fc91ff Fix release-note-generator to add final newline to generated files

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 bin/release-note-generator.ts (+2 -1)
➕ upcoming-release-notes/6641.md (+6 -0)

📄 Description

Files created by yarn generate:release-notes lack a trailing newline, causing yarn lint to fail due to the insert_final_newline = true requirement in .editorconfig.

Changes

  • Added newline character at end of template string in getFileContents() function
 function getFileContents(type: string, username: string, summary: string) {
   return `---
 category: ${type}
 authors: [${username}]
 ---
 
-${summary}`;
+${summary}
+`;
 }

Generated release note files now comply with formatting requirements enforced by oxfmt.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/actualbudget/actual/issues
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/actual/actual/node_modules/ts-node/dist/bin.js ./bin/release-note-generator.ts (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug]: yarn generate:release-notes generates files which trigger lint warnings</issue_title>
<issue_description>### Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When you run yarn generate:release-notes, it asks a series of questions and then creates a file based on your answers. However, if you use that file as-is, it will create a lint error when running yarn lint due to a missing newline at the end of the file

How can we reproduce the issue?

run yarn generate:release-notes and then yarn lint

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Other

Operating System

Linux</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6641 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/13/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `copilot/fix-release-notes-lint-warnings` --- ### 📝 Commits (3) - [`c150e62`](https://github.com/actualbudget/actual/commit/c150e62e996d64e7b30db996b0a0c19a342f18d5) Initial plan - [`57522f0`](https://github.com/actualbudget/actual/commit/57522f02af7ad2de85c89fe0ad37c29e5e1b28ca) Add release notes for PR #6641 - [`2fc91ff`](https://github.com/actualbudget/actual/commit/2fc91fffb21da4a7217ecfd0e50a5284732cd809) Fix release-note-generator to add final newline to generated files ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/release-note-generator.ts` (+2 -1) ➕ `upcoming-release-notes/6641.md` (+6 -0) </details> ### 📄 Description Files created by `yarn generate:release-notes` lack a trailing newline, causing `yarn lint` to fail due to the `insert_final_newline = true` requirement in `.editorconfig`. ## Changes - Added newline character at end of template string in `getFileContents()` function ```diff function getFileContents(type: string, username: string, summary: string) { return `--- category: ${type} authors: [${username}] --- -${summary}`; +${summary} +`; } ``` Generated release note files now comply with formatting requirements enforced by `oxfmt`. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `https://api.github.com/repos/actualbudget/actual/issues` > - Triggering command: `/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/actual/actual/node_modules/ts-node/dist/bin.js ./bin/release-note-generator.ts` (http block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/actualbudget/actual/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Bug]: yarn generate:release-notes generates files which trigger lint warnings</issue_title> > <issue_description>### Verified issue does not already exist? > > - [x] I have searched and found no existing issue > > ### What happened? > > When you run `yarn generate:release-notes`, it asks a series of questions and then creates a file based on your answers. However, if you use that file as-is, it will create a lint error when running `yarn lint` due to a missing newline at the end of the file > > ### How can we reproduce the issue? > > run `yarn generate:release-notes` and then `yarn lint` > > ### Where are you hosting Actual? > > Locally via Yarn > > ### What browsers are you seeing the problem on? > > Other > > ### Operating System > > Linux</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes actualbudget/actual#6640 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-14 03:41:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#69012