[PR #7019] [AI] Add per-package tsconfigs and typescript-strict-plugin for typecheck #6882

Closed
opened 2026-02-28 21:34:02 -06:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/actualbudget/actual/pull/7019

State: closed
Merged: Yes


Related: https://github.com/actualbudget/actual/issues/6309

Why do this?

  • allows us to incrementally enable "strict" mode for packages with no opt-out anymore
  • allows to fine-grain some other configs (i.e. "paths" for aliases)
  • maybe: allow us to incrementally move to tsgo

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.83 MB 0%
loot-core 1 5.82 MB → 5.82 MB (+217 B) +0.00%
api 1 4.43 MB → 4.43 MB (+165 B) +0.00%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.52 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/ca.js 188.02 kB 0%
static/js/da.js 106.46 kB 0%
static/js/de.js 180.27 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 168.63 kB 0%
static/js/es.js 173.67 kB 0%
static/js/fr.js 179.8 kB 0%
static/js/it.js 171.27 kB 0%
static/js/nb-NO.js 157.07 kB 0%
static/js/nl.js 106.47 kB 0%
static/js/pl.js 88.48 kB 0%
static/js/pt-BR.js 154.41 kB 0%
static/js/th.js 182.04 kB 0%
static/js/uk.js 214.89 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 637.68 kB 0%
static/js/TransactionList.js 106.22 kB 0%
static/js/wide.js 164.15 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 10.04 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.82 MB → 5.82 MB (+217 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/crdt/src/crdt/timestamp.ts 📈 +217 B (+3.08%) 6.87 kB → 7.08 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BwrdDDMW.js 0 B → 5.82 MB (+5.82 MB) -

Removed

Asset File Size % Changed
kcab.worker.Dbl7pyXw.js 5.82 MB → 0 B (-5.82 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
1 4.43 MB → 4.43 MB (+165 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/crdt/src/crdt/timestamp.ts 📈 +165 B (+2.70%) 5.96 kB → 6.13 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.43 MB → 4.43 MB (+165 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

**Original Pull Request:** https://github.com/actualbudget/actual/pull/7019 **State:** closed **Merged:** Yes --- Related: https://github.com/actualbudget/actual/issues/6309 Why do this? - allows us to incrementally enable "strict" mode for packages with no opt-out anymore - allows to fine-grain some other configs (i.e. "paths" for aliases) - maybe: allow us to incrementally move to tsgo <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.83 MB | 0% loot-core | 1 | 5.82 MB → 5.82 MB (+217 B) | +0.00% api | 1 | 4.43 MB → 4.43 MB (+165 B) | +0.00% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.52 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/ca.js | 188.02 kB | 0% static/js/da.js | 106.46 kB | 0% static/js/de.js | 180.27 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 168.63 kB | 0% static/js/es.js | 173.67 kB | 0% static/js/fr.js | 179.8 kB | 0% static/js/it.js | 171.27 kB | 0% static/js/nb-NO.js | 157.07 kB | 0% static/js/nl.js | 106.47 kB | 0% static/js/pl.js | 88.48 kB | 0% static/js/pt-BR.js | 154.41 kB | 0% static/js/th.js | 182.04 kB | 0% static/js/uk.js | 214.89 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 637.68 kB | 0% static/js/TransactionList.js | 106.22 kB | 0% static/js/wide.js | 164.15 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 10.04 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.82 MB → 5.82 MB (+217 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/crdt/src/crdt/timestamp.ts` | 📈 +217 B (+3.08%) | 6.87 kB → 7.08 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BwrdDDMW.js | 0 B → 5.82 MB (+5.82 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Dbl7pyXw.js | 5.82 MB → 0 B (-5.82 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.43 MB → 4.43 MB (+165 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/crdt/src/crdt/timestamp.ts` | 📈 +165 B (+2.70%) | 5.96 kB → 6.13 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.43 MB → 4.43 MB (+165 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end --->
GiteaMirror added the pull-request label 2026-02-28 21:34:02 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6882