[PR #6733] Fix reports to correctly render categories with identical names #6702

Closed
opened 2026-02-28 21:31:39 -06:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/actualbudget/actual/pull/6733

State: closed
Merged: Yes


Fixes

To reproduce: create two categories with identical names (in 2 different groups).

Before:
Screenshot 2026-01-20 at 22 05 54

After:
Screenshot 2026-01-20 at 22 05 46


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.4 MB → 14.4 MB (+1.09 kB) +0.01%
loot-core 1 5.83 MB 0%
api 1 4.37 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.4 MB → 14.4 MB (+1.09 kB) +0.01%
Changeset
File Δ Size
src/components/reports/spreadsheets/calculateLegend.ts 📈 +82 B (+7.46%) 1.07 kB → 1.15 kB
src/components/reports/graphs/LineGraph.tsx 📈 +512 B (+5.48%) 9.12 kB → 9.62 kB
src/components/reports/graphs/StackedBarGraph.tsx 📈 +514 B (+5.15%) 9.74 kB → 10.24 kB
src/components/reports/spreadsheets/custom-spreadsheet.ts 📈 +11 B (+0.19%) 5.73 kB → 5.74 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.05 MB → 1.05 MB (+1.09 kB) +0.10%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.24 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.66 kB 0%
static/js/de.js 171.61 kB 0%
static/js/en-GB.js 6.98 kB 0%
static/js/en.js 159.34 kB 0%
static/js/es.js 172.08 kB 0%
static/js/fr.js 177.92 kB 0%
static/js/it.js 172.51 kB 0%
static/js/nb-NO.js 158.17 kB 0%
static/js/nl.js 103.44 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 146.42 kB 0%
static/js/ru.js 106.97 kB 0%
static/js/sv.js 78.36 kB 0%
static/js/th.js 182.48 kB 0%
static/js/uk.js 216.45 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/narrow.js 640.86 kB 0%
static/js/TransactionList.js 101.58 kB 0%
static/js/wide.js 159.96 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.B3_-Z7dv.js 5.83 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.37 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.37 MB 0%
**Original Pull Request:** https://github.com/actualbudget/actual/pull/6733 **State:** closed **Merged:** Yes --- Fixes - https://github.com/actualbudget/actual/issues/3476 - https://github.com/actualbudget/actual/issues/6547 To reproduce: create two categories with identical names (in 2 different groups). Before: <img width="1042" height="649" alt="Screenshot 2026-01-20 at 22 05 54" src="https://github.com/user-attachments/assets/76f63c3c-8b4f-448e-ab5f-5aeddb540db6" /> After: <img width="1045" height="634" alt="Screenshot 2026-01-20 at 22 05 46" src="https://github.com/user-attachments/assets/bfd63674-2057-484a-ac43-4470948079f7" /> <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.4 MB → 14.4 MB (+1.09 kB) | +0.01% loot-core | 1 | 5.83 MB | 0% api | 1 | 4.37 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.4 MB → 14.4 MB (+1.09 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/spreadsheets/calculateLegend.ts` | 📈 +82 B (+7.46%) | 1.07 kB → 1.15 kB `src/components/reports/graphs/LineGraph.tsx` | 📈 +512 B (+5.48%) | 9.12 kB → 9.62 kB `src/components/reports/graphs/StackedBarGraph.tsx` | 📈 +514 B (+5.15%) | 9.74 kB → 10.24 kB `src/components/reports/spreadsheets/custom-spreadsheet.ts` | 📈 +11 B (+0.19%) | 5.73 kB → 5.74 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.05 MB → 1.05 MB (+1.09 kB) | +0.10% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.24 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.66 kB | 0% static/js/de.js | 171.61 kB | 0% static/js/en-GB.js | 6.98 kB | 0% static/js/en.js | 159.34 kB | 0% static/js/es.js | 172.08 kB | 0% static/js/fr.js | 177.92 kB | 0% static/js/it.js | 172.51 kB | 0% static/js/nb-NO.js | 158.17 kB | 0% static/js/nl.js | 103.44 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 146.42 kB | 0% static/js/ru.js | 106.97 kB | 0% static/js/sv.js | 78.36 kB | 0% static/js/th.js | 182.48 kB | 0% static/js/uk.js | 216.45 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/narrow.js | 640.86 kB | 0% static/js/TransactionList.js | 101.58 kB | 0% static/js/wide.js | 159.96 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B3_-Z7dv.js | 5.83 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.37 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.37 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end --->
GiteaMirror added the pull-request label 2026-02-28 21:31:39 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6702