github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-09 10:45:04 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6594] Bug/5679 payee filter #6624

New Issue
Closed
opened 2026-02-28 21:30:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:30:48 -06:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/actualbudget/actual/pull/6594

State: closed
Merged: Yes

Fixes issue #5679.

Before the fix, the payee filter was broken in that it allows users to try to filter by contains, does not contain, or matches, but the PayeeFilter does not support these types of filters. See the demo for the incorrect behavior:

https://github.com/user-attachments/assets/e2341a1b-86b4-4310-8dcb-f1cf95f8a489

After the fix, when a filter NOT associated with a distinct payee id is selected (contains, does not contain, matches), the payee filter will now instead use GenericInput, which does support this kind of filtering. See the demo for the new correct behavior:

https://github.com/user-attachments/assets/dcbed2f5-6ce8-4e40-b4bd-117d39b52786

This addresses user issues by allowing for expected behavior, that apparently used to work before the new payee filter was created. This does so without creating a new component, or modifying how payee filter works.

Tests were also created for the payee filter, including the default "is" filter.

EDIT - Also since I didn't explicitly mention it but the bot tagged the possibility, no AI was used in my code. The bot's suggestion for better release notes were used though.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6594 **State:** closed **Merged:** Yes --- <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fixes issue #5679. Before the fix, the payee filter was broken in that it allows users to try to filter by contains, does not contain, or matches, but the PayeeFilter does not support these types of filters. See the demo for the incorrect behavior: https://github.com/user-attachments/assets/e2341a1b-86b4-4310-8dcb-f1cf95f8a489 After the fix, when a filter NOT associated with a distinct payee id is selected (contains, does not contain, matches), the payee filter will now instead use GenericInput, which does support this kind of filtering. See the demo for the new correct behavior: https://github.com/user-attachments/assets/dcbed2f5-6ce8-4e40-b4bd-117d39b52786 This addresses user issues by allowing for expected behavior, that apparently used to work before the new payee filter was created. This does so without creating a new component, or modifying how payee filter works. Tests were also created for the payee filter, including the default "is" filter. EDIT - Also since I didn't explicitly mention it but the bot tagged the possibility, no AI was used in my code. The bot's suggestion for better release notes were used though.
GiteaMirror added the pull-request label 2026-02-28 21:30:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6624