github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6533] Fix LHV bank adapter not being loaded due to filename mismatch #6584

New Issue
Closed
opened 2026-02-28 21:30:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:30:20 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6533

State: closed
Merged: Yes

Summary

The LHV bank adapter (lhv-lhvbee22.js) was not being loaded because bank-factory.js filters for files containing underscores:

.filter(filename => filename.includes('_') && filename.endsWith('.js'));

This caused all LHV transactions to fall back to the generic IntegrationBank handler, which doesn't extract payee names from card transaction remittance info. As a result, card payments showed the full remittance string as the payee instead of the extracted merchant name.

Changes

  • Rename lhv-lhvbee22.js → lhv_lhvbee22.js to match the naming convention used by all other bank adapters
  • Update the corresponding test file and import statement

Test plan

  • Verified the bank factory now loads lhv_lhvbee22.js (43 banks loaded including LHV)
  • Verified no other references to the old filename exist
  • Run existing LHV bank adapter tests
  • Manual testing in a local production environment

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where card payment payee names displayed the full remittance string instead of the extracted merchant name.

  • Tests

    • Updated test import path resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6533 **State:** closed **Merged:** Yes --- ## Summary The LHV bank adapter (`lhv-lhvbee22.js`) was not being loaded because `bank-factory.js` filters for files containing underscores: ```javascript .filter(filename => filename.includes('_') && filename.endsWith('.js')); ``` This caused all LHV transactions to fall back to the generic `IntegrationBank` handler, which doesn't extract payee names from card transaction remittance info. As a result, card payments showed the full remittance string as the payee instead of the extracted merchant name. ## Changes - Rename `lhv-lhvbee22.js` → `lhv_lhvbee22.js` to match the naming convention used by all other bank adapters - Update the corresponding test file and import statement ## Test plan - [x] Verified the bank factory now loads `lhv_lhvbee22.js` (43 banks loaded including LHV) - [x] Verified no other references to the old filename exist - [x] Run existing LHV bank adapter tests - [x] Manual testing in a local production environment 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed an issue where card payment payee names displayed the full remittance string instead of the extracted merchant name. * **Tests** * Updated test import path resolution. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
GiteaMirror added the pull-request label 2026-02-28 21:30:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?