github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #485] [MERGED] Regenerate icons without the .web.js extension #65538

New Issue
Closed
opened 2026-05-13 23:31:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-13 23:31:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/485
Author: @j-f1
Created: 1/18/2023
Status: ✅ Merged
Merged: 1/20/2023
Merged by: @j-f1

Base: master ← Head: jed/dot-web-dot-js

📝 Commits (10+)

  • 22bc159 Regenerate icons without the .web.js extension
  • 7aa0ac9 Move icons in the root folder to a “v0” folder
  • 4f2d31f Remove generated index.js files
  • 46a58b2 Update generator to auto-remove deleted icons
  • 4df3c68 Add back AnimatedLoading + Loading
  • 58151c7 Add SVG files for missing icons
  • 9dd9cb0 lint fix
  • 2a01b36 the perils of (not) running a case-sensitive file system
  • 2ac43b9 Merge branch 'master' into jed/dot-web-dot-js
  • b6a8a7e Fix new import

📊 Changes

416 files changed (+1612 additions, -1306 deletions)

View changed files

📝 packages/desktop-client/src/components/AppBackground.js (+1 -1)
📝 packages/desktop-client/src/components/ManageRules.js (+1 -1)
📝 packages/desktop-client/src/components/Notifications.js (+2 -2)
📝 packages/desktop-client/src/components/SidebarWithData.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Account.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Filters.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+2 -2)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+1 -1)
📝 packages/desktop-client/src/components/modals/EditRule.js (+2 -2)
📝 packages/loot-design/package.json (+1 -0)
📝 packages/loot-design/src/components/CategorySelect.js (+1 -1)
📝 packages/loot-design/src/components/RecurringSchedulePicker.js (+2 -2)
📝 packages/loot-design/src/components/budget/index.js (+1 -1)
📝 packages/loot-design/src/components/common.js (+3 -3)
📝 packages/loot-design/src/components/icons.usage.js (+2 -2)
📝 packages/loot-design/src/components/manager/BudgetList.js (+1 -1)
📝 packages/loot-design/src/components/modals/PlaidExternalMsg.js (+1 -1)
📝 packages/loot-design/src/components/payees.js (+3 -3)
📝 packages/loot-design/src/components/table.js (+3 -3)
➕ packages/loot-design/src/svg/.gitignore (+1 -0)

...and 80 more files

📄 Description

This makes it easier to import since the file name will be correctly completed without the .web suffix. However, auto-imports will still add the Svg prefix to the component name because there is no way to remove it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/485 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/18/2023 **Status:** ✅ Merged **Merged:** 1/20/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/dot-web-dot-js` --- ### 📝 Commits (10+) - [`22bc159`](https://github.com/actualbudget/actual/commit/22bc159034d830444c59d62c0f722e7b79786680) Regenerate icons without the .web.js extension - [`7aa0ac9`](https://github.com/actualbudget/actual/commit/7aa0ac960a3fc80a1f8fc677e094742a2cd715bc) Move icons in the root folder to a “v0” folder - [`4f2d31f`](https://github.com/actualbudget/actual/commit/4f2d31f4d844a088a206c762653715e3eb0e67a4) Remove generated index.js files - [`46a58b2`](https://github.com/actualbudget/actual/commit/46a58b21f87e41b0819f920353cb787287fb945b) Update generator to auto-remove deleted icons - [`4df3c68`](https://github.com/actualbudget/actual/commit/4df3c683e5779eeec664b0a8aacfb4b10909315d) Add back AnimatedLoading + Loading - [`58151c7`](https://github.com/actualbudget/actual/commit/58151c7daa4014254986954eb1696842d69477c5) Add SVG files for missing icons - [`9dd9cb0`](https://github.com/actualbudget/actual/commit/9dd9cb09fe1a1c5ba81e2823ca2558e2b66aefa0) lint fix - [`2a01b36`](https://github.com/actualbudget/actual/commit/2a01b36ecb83806c2096132e7a6660d922a902da) the perils of (not) running a case-sensitive file system - [`2ac43b9`](https://github.com/actualbudget/actual/commit/2ac43b93fb4c6440ba190e6a722559048111c399) Merge branch 'master' into jed/dot-web-dot-js - [`b6a8a7e`](https://github.com/actualbudget/actual/commit/b6a8a7e81eb82f70b59a891a497dd2e5e75ccc09) Fix new import ### 📊 Changes **416 files changed** (+1612 additions, -1306 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/AppBackground.js` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRules.js` (+1 -1) 📝 `packages/desktop-client/src/components/Notifications.js` (+2 -2) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+2 -2) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+2 -2) 📝 `packages/loot-design/package.json` (+1 -0) 📝 `packages/loot-design/src/components/CategorySelect.js` (+1 -1) 📝 `packages/loot-design/src/components/RecurringSchedulePicker.js` (+2 -2) 📝 `packages/loot-design/src/components/budget/index.js` (+1 -1) 📝 `packages/loot-design/src/components/common.js` (+3 -3) 📝 `packages/loot-design/src/components/icons.usage.js` (+2 -2) 📝 `packages/loot-design/src/components/manager/BudgetList.js` (+1 -1) 📝 `packages/loot-design/src/components/modals/PlaidExternalMsg.js` (+1 -1) 📝 `packages/loot-design/src/components/payees.js` (+3 -3) 📝 `packages/loot-design/src/components/table.js` (+3 -3) ➕ `packages/loot-design/src/svg/.gitignore` (+1 -0) _...and 80 more files_ </details> ### 📄 Description This makes it easier to import since the file name will be correctly completed without the `.web` suffix. However, auto-imports will still add the `Svg` prefix to the component name because there is no way to remove it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-13 23:31:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#65538