github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6463] chore: Add a meta.name to the eslint plugin. #6545

New Issue
Closed
opened 2026-02-28 21:29:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:29:50 -06:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/actualbudget/actual/pull/6463

State: closed
Merged: Yes

Noticed this'll break when you upgrade oxlint if this isn't done (noticed with https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629/job/58631736649), so figured I'd contribute that :)

Also fix the config for the glob patterns in the no-restricted-imports rule. Noticed this by running yarn oxlint --report-unused-disable-directives-severity=error and taking a look at the directives that were unnecessarily-disabled. oxlint uses rust fast-glob for glob matching generally, and so the * character matches everything except / separators. And so you'd be missing files nested under directories with the previous glob.

Summary by CodeRabbit

  • Chores
    • Enhanced the ESLint plugin configuration by adding name metadata, improving plugin identification and proper integration with ESLint tooling.

✏️ Tip: You can customize this high-level summary in your review settings.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6463 **State:** closed **Merged:** Yes --- <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Noticed this'll break when you upgrade oxlint if this isn't done (noticed with https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629/job/58631736649), so figured I'd contribute that :) Also fix the config for the glob patterns in the no-restricted-imports rule. Noticed this by running `yarn oxlint --report-unused-disable-directives-severity=error` and taking a look at the directives that were unnecessarily-disabled. oxlint uses rust fast-glob for glob matching generally, and so the `*` character matches everything _except_ `/` separators. And so you'd be missing files nested under directories with the previous glob. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced the ESLint plugin configuration by adding name metadata, improving plugin identification and proper integration with ESLint tooling. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
GiteaMirror added the pull-request label 2026-02-28 21:29:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6545