github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-10 23:54:00 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #73] [MERGED] Add a CI workflow to perform builds of api, web and electron packages #65369

New Issue
Closed
opened 2026-05-13 23:19:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-13 23:19:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/73
Author: @TomAFrench
Created: 5/29/2022
Status: ✅ Merged
Merged: 6/29/2022
Merged by: @jlongster

Base: master ← Head: build-ci

📝 Commits (10+)

  • cd57bd3 ci: build api and web packages in CI
  • 49585f8 ci: add electron build to CI
  • 0492cae ci: avoid duplicate linting in CI
  • 4de6746 ci: cache node_modules per runner os
  • 166be0e ci: always use bash as the shell
  • a696f22 ci: avoid attempting to get CSC_KEY_PASSWORD interactively in github actions
  • 004b176 build: remove signing config
  • d78898e docs: add comment explaining how to reactivate code signing
  • 035ac21 ci: only build electron app on master
  • b7454ef ci: turn boilerplate into composite action

📊 Changes

7 files changed (+89 additions, -20 deletions)

View changed files

➕ .github/actions/setup/action.yml (+19 -0)
➕ .github/workflows/build.yml (+51 -0)
📝 .github/workflows/lint.yml (+2 -13)
📝 bin/package (+5 -3)
📝 bin/package-browser (+5 -1)
📝 packages/desktop-electron/afterSignHook.js (+6 -0)
📝 packages/desktop-electron/package.json (+1 -3)

📄 Description

Builds on top of #53, #55 and #72 as they all fix issues which causes the CI build to blow up.

This PR adds a github workflow which checks that running the steps in releasing.md succeeds and that we can build the electron app on linux/mac/windows platforms.

This also includes some small changes to bin/package and bin/package-browser to avoid performing linting in CI but it shouldn't affect usage from the CLI.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/73 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 5/29/2022 **Status:** ✅ Merged **Merged:** 6/29/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `build-ci` --- ### 📝 Commits (10+) - [`cd57bd3`](https://github.com/actualbudget/actual/commit/cd57bd3cac702048e00270cf0282bc28aed7b85d) ci: build api and web packages in CI - [`49585f8`](https://github.com/actualbudget/actual/commit/49585f81029cd2b5b72b4eb8bd8f2a430faf92d8) ci: add electron build to CI - [`0492cae`](https://github.com/actualbudget/actual/commit/0492cae65dd802da7523ced483b5bf2a2c03a3db) ci: avoid duplicate linting in CI - [`4de6746`](https://github.com/actualbudget/actual/commit/4de67462b9edd2c572f52c2433022eb15a84c7b8) ci: cache node_modules per runner os - [`166be0e`](https://github.com/actualbudget/actual/commit/166be0ee53456e9c06967d6da7c21a9b6dd95756) ci: always use bash as the shell - [`a696f22`](https://github.com/actualbudget/actual/commit/a696f2290dfa5b8afe5c2683182865f81c3fa62c) ci: avoid attempting to get CSC_KEY_PASSWORD interactively in github actions - [`004b176`](https://github.com/actualbudget/actual/commit/004b176ddf1bf63b397ba8a983fe3d1e6c9aeb18) build: remove signing config - [`d78898e`](https://github.com/actualbudget/actual/commit/d78898ea1817845f8f1f86322564269adb31e492) docs: add comment explaining how to reactivate code signing - [`035ac21`](https://github.com/actualbudget/actual/commit/035ac2166340b0023ceea747a5934cce1a106938) ci: only build electron app on master - [`b7454ef`](https://github.com/actualbudget/actual/commit/b7454efd3059ef39ccb054280a9eadc57525cf9e) ci: turn boilerplate into composite action ### 📊 Changes **7 files changed** (+89 additions, -20 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/setup/action.yml` (+19 -0) ➕ `.github/workflows/build.yml` (+51 -0) 📝 `.github/workflows/lint.yml` (+2 -13) 📝 `bin/package` (+5 -3) 📝 `bin/package-browser` (+5 -1) 📝 `packages/desktop-electron/afterSignHook.js` (+6 -0) 📝 `packages/desktop-electron/package.json` (+1 -3) </details> ### 📄 Description Builds on top of #53, #55 and #72 as they all fix issues which causes the CI build to blow up. This PR adds a github workflow which checks that running the steps in [releasing.md](https://github.com/actualbudget/actual/blob/master/docs/releasing.md) succeeds and that we can build the electron app on linux/mac/windows platforms. This also includes some small changes to `bin/package` and `bin/package-browser` to avoid performing linting in CI but it shouldn't affect usage from the CLI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-13 23:19:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#65369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?