mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
Closed
opened 2026-05-11 21:53:35 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a
enforce-append-only-migrations-ci
claude/error-codes-worker-boundary-26i5uu
api-browser-custom-data-dir
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
cross-version-sync-compat
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#64752
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/6834
Author: @bonroyage
Created: 2/1/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @youngcw
Base:
master← Head:filter-category-groups📝 Commits (10+)
1308b84Add filter by category groupse3e55e7Add tests81ed024Add release notesfb6bb19[autofix.ci] apply automated fixesbabc583Fix typecheck findings47d2bc0Fix modal127b92fAddress nitpick comment (filterBy)0b6d12aFix e2e testsc71385cMerge branch 'master' into filter-category-groups-2a7d2c9cMerge branch 'master' into filter-category-groups-2📊 Changes
36 files changed (+552 additions, -52 deletions)
View changed files
📝
packages/desktop-client/e2e/transactions.test.ts(+45 -15)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-1-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-10-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-11-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-12-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-3-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png(+0 -0)📝
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-1-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-10-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-11-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-12-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-2-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-3-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-4-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-5-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-6-chromium-linux.png(+0 -0)➕
packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-category-group-7-chromium-linux.png(+0 -0)...and 16 more files
📄 Description
Resolves https://github.com/actualbudget/actual/issues/3791 and resolves https://github.com/actualbudget/actual/issues/4031
With this PR, I hope to add filtering support for category groups in reports. The reasoning for this is to create graphs or statistics that include everything in a certain group without having to adjust the filters whenever a category gets added or moved to another group.
I only noticed @ericparton's closed PR (#6471) after I had made all the necessary UI changes and kept running into query issues (see below). Since his PR is pretty much the same, with minor differences in naming and the selector, I also credited him in the release notes. His solution (removing
noMapping) helped me overcome the query issues, everything seems to work fine and all tests still pass. I don't know if there are any other side effects that I didn't see, or if there is another better solution, so if there is, I'm all ears.Screenshots:
The query errors I ran into when
noMappingwas set to true:I also tried using
cat_groupinstead ofgroup, since that's the column name incategories, but it just resulted in a different error. I considered looking into how to change the column name fromcat_grouptogroup, but at the moment I can't see what implications that would have, and where I would have even begun.Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
src/accounts/mutations.tssrc/components/autocomplete/CategoryGroupAutocomplete.tsxsrc/components/modals/CategoryGroupAutocompleteModal.tsxsrc/accounts/queries.tssrc/hooks/useClosedAccounts.tssrc/hooks/useOffBudgetAccounts.tssrc/hooks/useOnBudgetAccounts.tssrc/components/util/GenericInput.tsxsrc/hooks/useAccount.tssrc/components/rules/Value.tsxsrc/components/filters/FiltersMenu.tsxsrc/modals/modalsSlice.tshome/runner/work/actual/actual/packages/loot-core/src/shared/rules.tssrc/components/accounts/Account.tsxsrc/components/modals/CreateLocalAccountModal.tsxsrc/components/banksync/EditSyncAccount.tsxsrc/components/mobile/banksync/MobileBankSyncAccountEditPage.tsxsrc/components/mobile/accounts/AccountPage.tsxsrc/global-events.tssrc/components/Modals.tsxsrc/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsxsrc/components/sidebar/Account.tsxsrc/components/modals/SelectLinkedAccountsModal.tsxsrc/components/modals/CloseAccountModal.tsxsrc/components/accounts/AccountSyncCheck.tsxsrc/components/mobile/accounts/AccountTransactions.tsxsrc/sync-events.tssrc/components/FinancesApp.tsxsrc/budget/mutations.tssrc/components/reports/reports/CustomReport.tsxsrc/components/mobile/accounts/AccountsPage.tsxsrc/components/sidebar/Accounts.tsxsrc/components/rules/RuleEditor.tsxsrc/components/autocomplete/CategoryAutocomplete.tsxsrc/components/rules/RuleRow.tsxsrc/hooks/useFailedAccounts.tssrc/app/appSlice.tssrc/hooks/useAccounts.tssrc/accounts/accountsSlice.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.tshome/runner/work/actual/actual/packages/loot-core/src/server/api.tshome/runner/work/actual/actual/packages/loot-core/src/server/aql/compiler.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
src/shared/rules.tssrc/server/accounts/app.tssrc/server/transactions/transaction-rules.tssrc/server/api.tssrc/server/aql/compiler.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.