github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6300] [MERGED] Fix lint violations (vol.2) #64422

New Issue
Closed
opened 2026-05-11 21:32:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 21:32:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6300
Author: @MatissJanis
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/8/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-other-lint-issues

📝 Commits (5)

  • f56695b Fix lint violations
  • 21d53e9 Refactor code for clarity and consistency
  • 84cbbf9 Merge branch 'master' into matiss/fix-other-lint-issues
  • d84b84f Fix unused variable warning in electronApp fixture
  • f5905d7 Fix linting comment in fixtures.ts

📊 Changes

16 files changed (+49 additions, -37 deletions)

View changed files

📝 .oxlintrc.json (+0 -5)
📝 packages/crdt/src/crdt/merkle.ts (+1 -1)
📝 packages/desktop-client/src/components/CommandBar.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/FilterList.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/ReportList.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx (+2 -2)
📝 packages/desktop-client/src/components/mobile/budget/IncomeCategoryListItem.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/budget/IncomeGroup.tsx (+1 -1)
📝 packages/desktop-electron/e2e/fixtures.ts (+1 -0)
📝 packages/docs/docs/api/APIList.js (+4 -1)
📝 packages/docs/docs/api/types.js (+13 -5)
📝 packages/docs/src/components/Key.jsx (+9 -11)
📝 packages/loot-core/src/server/main.test.ts (+6 -5)
📝 packages/loot-core/src/server/schedules/find-schedules.ts (+1 -1)
➕ upcoming-release-notes/6300.md (+6 -0)

📄 Description

Summary

This PR improves code readability and maintainability across various components:

Changes

  • Changed while (1) to while (true) for better clarity
  • Simplified conditional checks by removing unnecessary boolean casts
  • Added missing key props in mapped elements to ensure proper rendering in lists
  • Adjusted the handling of hidden states in budget components for clearer logic
  • Cleaned up linting rules in .oxlintrc.json to streamline configuration

Files Modified

  • .oxlintrc.json
  • packages/crdt/src/crdt/merkle.ts
  • packages/desktop-client/src/components/CommandBar.tsx
  • packages/desktop-client/src/components/autocomplete/Autocomplete.tsx
  • packages/desktop-client/src/components/autocomplete/FilterList.tsx
  • packages/desktop-client/src/components/autocomplete/ReportList.tsx
  • packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx
  • packages/desktop-client/src/components/mobile/budget/IncomeCategoryListItem.tsx
  • packages/desktop-client/src/components/mobile/budget/IncomeGroup.tsx
  • packages/desktop-electron/e2e/fixtures.ts
  • packages/docs/docs/api/APIList.js
  • packages/docs/docs/api/types.js
  • packages/docs/src/components/Key.jsx
  • packages/loot-core/src/server/main.test.ts
  • packages/loot-core/src/server/schedules/find-schedules.ts

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6300 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-other-lint-issues` --- ### 📝 Commits (5) - [`f56695b`](https://github.com/actualbudget/actual/commit/f56695b08d4bbcf578f1aac3c73e0695b077c458) Fix lint violations - [`21d53e9`](https://github.com/actualbudget/actual/commit/21d53e98bc7a184f3db36113418b99e50e225c16) Refactor code for clarity and consistency - [`84cbbf9`](https://github.com/actualbudget/actual/commit/84cbbf9ff8e4f098dda1152d0bacc44be5fcd8fe) Merge branch 'master' into matiss/fix-other-lint-issues - [`d84b84f`](https://github.com/actualbudget/actual/commit/d84b84f4aa3b9bd5fb9fa66f8cf6da9afe6fb45f) Fix unused variable warning in electronApp fixture - [`f5905d7`](https://github.com/actualbudget/actual/commit/f5905d7cafb8718f2bbeb5b73fb723c4f0f85f9d) Fix linting comment in fixtures.ts ### 📊 Changes **16 files changed** (+49 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+0 -5) 📝 `packages/crdt/src/crdt/merkle.ts` (+1 -1) 📝 `packages/desktop-client/src/components/CommandBar.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/FilterList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/ReportList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/mobile/budget/IncomeCategoryListItem.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/budget/IncomeGroup.tsx` (+1 -1) 📝 `packages/desktop-electron/e2e/fixtures.ts` (+1 -0) 📝 `packages/docs/docs/api/APIList.js` (+4 -1) 📝 `packages/docs/docs/api/types.js` (+13 -5) 📝 `packages/docs/src/components/Key.jsx` (+9 -11) 📝 `packages/loot-core/src/server/main.test.ts` (+6 -5) 📝 `packages/loot-core/src/server/schedules/find-schedules.ts` (+1 -1) ➕ `upcoming-release-notes/6300.md` (+6 -0) </details> ### 📄 Description ## Summary This PR improves code readability and maintainability across various components: ### Changes - Changed `while (1)` to `while (true)` for better clarity - Simplified conditional checks by removing unnecessary boolean casts - Added missing `key` props in mapped elements to ensure proper rendering in lists - Adjusted the handling of hidden states in budget components for clearer logic - Cleaned up linting rules in `.oxlintrc.json` to streamline configuration ### Files Modified - `.oxlintrc.json` - `packages/crdt/src/crdt/merkle.ts` - `packages/desktop-client/src/components/CommandBar.tsx` - `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` - `packages/desktop-client/src/components/autocomplete/FilterList.tsx` - `packages/desktop-client/src/components/autocomplete/ReportList.tsx` - `packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx` - `packages/desktop-client/src/components/mobile/budget/IncomeCategoryListItem.tsx` - `packages/desktop-client/src/components/mobile/budget/IncomeGroup.tsx` - `packages/desktop-electron/e2e/fixtures.ts` - `packages/docs/docs/api/APIList.js` - `packages/docs/docs/api/types.js` - `packages/docs/src/components/Key.jsx` - `packages/loot-core/src/server/main.test.ts` - `packages/loot-core/src/server/schedules/find-schedules.ts` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 21:32:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#64422