[PR #5918] [MERGED] budgetfilesSlice: Fix paste-o in fallback sorting by ID #64196

Closed
opened 2026-05-11 21:18:24 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5918
Author: @db-src
Created: 10/13/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @matt-fidd

Base: master ← Head: patch-1


📝 Commits (4)

  • d2288fb budgetfilesSlice: Fix paste-o in fallback sorting by ID
  • 9e1af57 Create 5918.md
  • 44aea1e 5918.md: Clarify
  • 5514c63 5918.md: Ah, those square brackets don't just indicate a placeholder

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts (+1 -1)
➕ upcoming-release-notes/5918.md (+6 -0)

📄 Description

The sortFiles() function, in case of tied names, attempts to fall back to sorting by (local or cloud) file ID. However, it is using the fields from the x/LHS file object as the projection for the y/RHS object too. This was likely a copy-paste error. This commit fixes that by correcting the object references to the y object.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5918 **Author:** [@db-src](https://github.com/db-src) **Created:** 10/13/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (4) - [`d2288fb`](https://github.com/actualbudget/actual/commit/d2288fb80287ab2d7fd51b12d3ba99bb63c0f1e2) budgetfilesSlice: Fix paste-o in fallback sorting by ID - [`9e1af57`](https://github.com/actualbudget/actual/commit/9e1af57709d85203d6934d295259846008fa2c94) Create 5918.md - [`44aea1e`](https://github.com/actualbudget/actual/commit/44aea1ee3f1a24be0735a61e4dd7d353bdbe2948) 5918.md: Clarify - [`5514c63`](https://github.com/actualbudget/actual/commit/5514c636ecea71a3a0b31a0117f16dddcc88d9c7) 5918.md: Ah, those square brackets don't just indicate a placeholder ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts` (+1 -1) ➕ `upcoming-release-notes/5918.md` (+6 -0) </details> ### 📄 Description The `sortFiles()` function, in case of tied names, attempts to fall back to sorting by (local or cloud) file ID. However, it is using the fields from the `x`/LHS file object as the projection for the `y`/RHS object too. This was likely a copy-paste error. This commit fixes that by correcting the object references to the `y` object. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 21:18:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#64196