github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-12 10:02:28 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[Bug]: Report budget Visual regression #640

New Issue
Closed
opened 2026-02-28 19:12:23 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-02-28 19:12:23 -06:00
Owner
Copy Link

Originally created by @shall0pass on GitHub (Sep 21, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

There appears to be a regression in the Report budget. The dark line under September used to be a much lighter gray. I'm also not sure when the month received an underline. Was that on purpose?

Now:
image

Before:
image

What error did you receive?

No response

Where are you hosting Actual?

Other

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

Originally created by @shall0pass on GitHub (Sep 21, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? There appears to be a regression in the Report budget. The dark line under September used to be a much lighter gray. I'm also not sure when the month received an underline. Was that on purpose? Now: ![image](https://github.com/actualbudget/actual/assets/20625555/f3664900-cfaa-4403-ae1c-66e2f7128d4d) Before: ![image](https://github.com/actualbudget/actual/assets/20625555/fa8b232d-d205-45f8-8d06-84faf59b6a44) ### What error did you receive? _No response_ ### Where are you hosting Actual? Other ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 11
GiteaMirror added the regressionbug labels 2026-02-28 19:12:23 -06:00
GiteaMirror commented 2026-02-28 19:12:24 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Sep 21, 2023):

cc @carkom

@MatissJanis commented on GitHub (Sep 21, 2023): cc @carkom
GiteaMirror commented 2026-02-28 19:12:24 -06:00
Author
Owner
Copy Link

@carkom commented on GitHub (Sep 22, 2023):

I'm unable to duplicate this. Everything I try shows no underline and no border changes. Can anyone confirm this bug?

@carkom commented on GitHub (Sep 22, 2023): I'm unable to duplicate this. Everything I try shows no underline and no border changes. Can anyone confirm this bug?
GiteaMirror commented 2026-02-28 19:12:25 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Sep 22, 2023):

@carkom you'll need to enable the "budget mode" feature flag and then switch to rollover budget to reproduce.

@MatissJanis commented on GitHub (Sep 22, 2023): @carkom you'll need to enable the "budget mode" feature flag and then switch to rollover budget to reproduce.
GiteaMirror commented 2026-02-28 19:12:25 -06:00
Author
Owner
Copy Link

@carkom commented on GitHub (Sep 28, 2023):

Thanks for directing me. Here is what I see on current master. The dark line is gone and the underscore is not a dark theme regression it's been there long before any dark theme changes were merged. Happy to fix it though!

image

@carkom commented on GitHub (Sep 28, 2023): Thanks for directing me. Here is what I see on current master. The dark line is gone and the underscore is not a dark theme regression it's been there long before any dark theme changes were merged. Happy to fix it though! ![image](https://github.com/actualbudget/actual/assets/55785687/26fa2c90-9e60-47e5-8ba1-cadd5f3e79f9)
GiteaMirror commented 2026-02-28 19:12:26 -06:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Sep 28, 2023):

I'm still seeing it on master. It only changes when you collapse the monthly header. I agree the underline was there a long time and wasn't part of the dark theme PRs.
Screenshot_20230928-102801

@shall0pass commented on GitHub (Sep 28, 2023): I'm still seeing it on master. It only changes when you collapse the monthly header. I agree the underline was there a long time and wasn't part of the dark theme PRs. ![Screenshot_20230928-102801](https://github.com/actualbudget/actual/assets/20625555/07be633e-e986-48d8-9d7d-f518b279d828)
GiteaMirror commented 2026-02-28 19:12:26 -06:00
Author
Owner
Copy Link

@carkom commented on GitHub (Sep 28, 2023):

Ahh, the header collapse! How'd I miss it? I see it now. Thanks!

@carkom commented on GitHub (Sep 28, 2023): Ahh, the header collapse! How'd I miss it? I see it now. Thanks!
GiteaMirror commented 2026-02-28 19:12:26 -06:00
Author
Owner
Copy Link

@carkom commented on GitHub (Sep 28, 2023):

Okay, have the border fixed.

Here is the underline code. Would you like me to remove it?

          currentMonth === month && { textDecoration: 'underline' },
@carkom commented on GitHub (Sep 28, 2023): Okay, have the border fixed. Here is the underline code. Would you like me to remove it? currentMonth === month && { textDecoration: 'underline' },
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug regression
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#640
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?