github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-20 14:11:32 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #6150] Extract schedule edit form into separate reusable component #6354

New Issue
Closed
opened 2026-02-28 21:27:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:27:09 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6150

State: closed
Merged: Yes

Summary

This PR extracts the schedule edit form from ScheduleEditModal into a separate reusable component ScheduleEditForm. This refactoring enables the form to be reused in other contexts, particularly for the mobile schedules page.

Changes

  • Created ScheduleEditForm.tsx: A new reusable component containing:

    • All form fields (name, payee, account, amount, date)
    • Transactions table with linked/matched mode switching
    • Footer buttons (Cancel/Save) with error display
    • NoTransactionsMessage component

  • Updated ScheduleEditModal.tsx:

    • Removed form UI code (moved to ScheduleEditForm)
    • Removed unused imports
    • Updated to use the new form component
    • Simplified onSave function signature

Benefits

  • Reusability: The form component can now be used in mobile views and other contexts
  • Separation of concerns: Modal handles state/logic, form handles UI
  • Maintainability: Form changes are isolated to a single component
  • Type safety: Shared types ensure consistency

Testing

  • ✅ All lint checks pass
  • ✅ Typecheck passes
  • ✅ No functionality changes - existing behavior preserved
**Original Pull Request:** https://github.com/actualbudget/actual/pull/6150 **State:** closed **Merged:** Yes --- ## Summary This PR extracts the schedule edit form from `ScheduleEditModal` into a separate reusable component `ScheduleEditForm`. This refactoring enables the form to be reused in other contexts, particularly for the mobile schedules page. ## Changes - **Created `ScheduleEditForm.tsx`**: A new reusable component containing: - All form fields (name, payee, account, amount, date) - Transactions table with linked/matched mode switching - Footer buttons (Cancel/Save) with error display - `NoTransactionsMessage` component - **Updated `ScheduleEditModal.tsx`**: - Removed form UI code (moved to `ScheduleEditForm`) - Removed unused imports - Updated to use the new form component - Simplified `onSave` function signature ## Benefits - **Reusability**: The form component can now be used in mobile views and other contexts - **Separation of concerns**: Modal handles state/logic, form handles UI - **Maintainability**: Form changes are isolated to a single component - **Type safety**: Shared types ensure consistency ## Testing - ✅ All lint checks pass - ✅ Typecheck passes - ✅ No functionality changes - existing behavior preserved
GiteaMirror added the pull-request label 2026-02-28 21:27:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?