github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-12 01:52:09 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #4568] [MERGED] ♻️ (components) refactor useResponsive and move to comp. lib #63445

New Issue
Closed
opened 2026-05-11 20:34:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 20:34:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4568
Author: @MatissJanis
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/responsive

📝 Commits (3)

  • fa6c05f ♻️ (components) refactor useResponsive and move to comp. lib
  • abf3e23 Release notes
  • 2cf2938 Merge branch 'master' into matiss/responsive

📊 Changes

55 files changed (+224 additions, -248 deletions)

View changed files

📝 packages/component-library/package.json (+3 -1)
➕ packages/component-library/src/hooks/useResponsive.ts (+23 -0)
📝 packages/desktop-client/src/components/App.tsx (+29 -34)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+2 -2)
📝 packages/desktop-client/src/components/Notes.tsx (+3 -3)
📝 packages/desktop-client/src/components/Notifications.tsx (+4 -4)
📝 packages/desktop-client/src/components/Page.tsx (+2 -4)
📝 packages/desktop-client/src/components/PrivacyFilter.tsx (+1 -2)
📝 packages/desktop-client/src/components/ThemeSelector.tsx (+6 -3)
📝 packages/desktop-client/src/components/Titlebar.tsx (+10 -10)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx (+2 -2)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+2 -3)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+3 -3)
📝 packages/desktop-client/src/components/autocomplete/ItemHeader.tsx (+2 -3)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx (+9 -12)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+3 -3)
📝 packages/desktop-client/src/components/banksync/index.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx (+3 -3)
📝 packages/desktop-client/src/components/common/Modal.tsx (+4 -5)
📝 packages/desktop-client/src/components/manager/BudgetList.tsx (+7 -3)

...and 35 more files

📄 Description

Apologies for the large PR

Two things in this PR.

  1. refactored useResponsive - removed ResponsiveProvider context. It was necessary before as we were relying on document to calculate widths. Whereas now we use a hook that react to window size updates. Hence we no longer need to context provider;
  2. moved the hook to the component library so it could be used in plugins and such.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4568 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/responsive` --- ### 📝 Commits (3) - [`fa6c05f`](https://github.com/actualbudget/actual/commit/fa6c05f30f267e26c76afec9822f86c6168c765a) :recycle: (components) refactor useResponsive and move to comp. lib - [`abf3e23`](https://github.com/actualbudget/actual/commit/abf3e230bc98953da6e9aa75add5fb05e38da2e9) Release notes - [`2cf2938`](https://github.com/actualbudget/actual/commit/2cf2938942a383bb7b7e64eed387adb28181c8dd) Merge branch 'master' into matiss/responsive ### 📊 Changes **55 files changed** (+224 additions, -248 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/package.json` (+3 -1) ➕ `packages/component-library/src/hooks/useResponsive.ts` (+23 -0) 📝 `packages/desktop-client/src/components/App.tsx` (+29 -34) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/Notes.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/Page.tsx` (+2 -4) 📝 `packages/desktop-client/src/components/PrivacyFilter.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+6 -3) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+10 -10) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/autocomplete/ItemHeader.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx` (+9 -12) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/banksync/index.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+4 -5) 📝 `packages/desktop-client/src/components/manager/BudgetList.tsx` (+7 -3) _...and 35 more files_ </details> ### 📄 Description Apologies for the large PR Two things in this PR. 1. refactored useResponsive - removed ResponsiveProvider context. It was necessary before as we were relying on document to calculate widths. Whereas now we use a hook that react to window size updates. Hence we no longer need to context provider; 2. moved the hook to the component library so it could be used in plugins and such. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 20:34:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#63445
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?