mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-10 20:23:07 -05:00
[PR #6082] Sync cleared error #6311
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#6311
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/actualbudget/actual/pull/6082
State: closed
Merged: Yes
Fixes#5922 https://github.com/actualbudget/actual/issues/5922
Adjusted single line to change precedence for how the cleared field is reconciled upon importing in the sync process.
This assumes that if a user has an existing transaction as cleared, then during the merging process it should remain cleared regardless of the imported transaction.
Testing using OFX import and replicating the steps provided in the issue. After replicating I made this fix, rebuilt and tested again. This has the intended effect of leaving transactions which were manually cleared
This is my first PR so hopefully someone with more experience can come along and say if they would have any other suggestions.
The only situation I can imagine is if a user is manually UNclearing transactions that come in cleared. This would break that. However I don't see any way to quickly see if the cleared field is different than the value on original import. In an ideal world there would be something like a .userModified to identify if the value has been changed by the user either by rules or manually. To allow a more definitive reconciliation of synced/imported items.