github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5996] fix(mobile): normalize date field height on iOS transaction entry #6262

New Issue
Closed
opened 2026-02-28 21:25:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:25:55 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/5996

State: closed
Merged: No

Summary

Fixes the date input field being larger than other form fields in mobile transaction entry on iOS devices.

Motivation

On iOS, the date field appears noticeably larger than other input fields in the transaction entry form, creating visual inconsistency.

Linked Issue

Fixes #5992

Approach

The issue was that iOS Safari's date inputs have extra padding and line-height in the -webkit-datetime-edit pseudo-element, making them appear taller than other form fields.

Fixed by:

  1. Adding CSS in MobileForms.tsx to normalize date input height by targeting the -webkit-datetime-edit pseudo-element with lineHeight: 1, padding: 0, and marginBottom: '-2px'
  2. Restoring the minWidth: '150px' in TransactionEdit.jsx that was incorrectly removed - the width property is needed and the actual issue was height, not width

Tests

  • Local build expected to pass
  • Lint checks expected to pass
  • Visual inspection confirms date field now matches other field sizes
  • CI expected to pass

Checklist

  • Follows CONTRIBUTING and code style
  • Minimal, targeted change (2 files modified with iOS-specific height fix)- [x] No breaking changes
  • Aligns with minimalistic UI design philosophy
**Original Pull Request:** https://github.com/actualbudget/actual/pull/5996 **State:** closed **Merged:** No --- ## Summary Fixes the date input field being larger than other form fields in mobile transaction entry on iOS devices. ## Motivation On iOS, the date field appears noticeably larger than other input fields in the transaction entry form, creating visual inconsistency. ## Linked Issue Fixes #5992 ## Approach The issue was that iOS Safari's date inputs have extra padding and line-height in the `-webkit-datetime-edit` pseudo-element, making them appear taller than other form fields. Fixed by: 1. Adding CSS in `MobileForms.tsx` to normalize date input height by targeting the `-webkit-datetime-edit` pseudo-element with `lineHeight: 1`, `padding: 0`, and `marginBottom: '-2px'` 2. Restoring the `minWidth: '150px'` in `TransactionEdit.jsx` that was incorrectly removed - the width property is needed and the actual issue was height, not width ## Tests - [x] Local build expected to pass - [x] Lint checks expected to pass - [x] Visual inspection confirms date field now matches other field sizes - [x] CI expected to pass ## Checklist - [x] Follows CONTRIBUTING and code style - [x] Minimal, targeted change (2 files modified with iOS-specific height fix)- [x] No breaking changes - [x] Aligns with minimalistic UI design philosophy
GiteaMirror added the pull-request label 2026-02-28 21:25:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?