github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5804] [MERGED] Mobile rules - refactor to use react-aria GridList component #6131

New Issue
Closed
opened 2026-02-28 21:24:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:24:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5804
Author: @MatissJanis
Created: 9/27/2025
Status: ✅ Merged
Merged: 10/5/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/mobile-rules-gridlist

📝 Commits (8)

  • 908b3e3 Refactor MobileRulesPage and RulesList components to use react-aria GridList for improved performance and simplify rule loading logic. Removed load more functionality and adjusted item rendering in RulesListItem for better structure and readability.
  • 26d8812 Refactor RulesList and RulesListItem components to remove unused Trans import from react-i18next, streamlining the codebase.
  • 17b2db2 Update MobileRulesPage to use 'listitem' role instead of 'button' for improved accessibility in rule retrieval methods.
  • a9e30c5 Refactor MobileRulesPage to enhance rule retrieval methods by using a more specific locator for visible rules, improving accuracy and maintainability.
  • 6cf3b70 Update MobileRulesPage to refine rule filtering by removing 'DEFAULT' from the locator, enhancing the specificity of visible rules.
  • 747aa7f Refactor MobileRulesPage to enhance rule retrieval by using 'grid' and 'row' roles for improved accessibility and specificity in rule filtering.
  • 70bc91e Update MobileRulesPage and RulesListItem to improve rule stage retrieval by using a specific test ID for the stage badge, enhancing code clarity and maintainability.
  • 6c8e0ff Refactor mobile rules list item and page model

📊 Changes

5 files changed (+166 additions, -198 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/mobile-rules-page.ts (+3 -6)
📝 packages/desktop-client/src/components/mobile/rules/MobileRulesPage.tsx (+3 -17)
📝 packages/desktop-client/src/components/mobile/rules/RulesList.tsx (+18 -29)
📝 packages/desktop-client/src/components/mobile/rules/RulesListItem.tsx (+136 -146)
➕ upcoming-release-notes/5804.md (+6 -0)

📄 Description

Refactor MobileRulesPage and RulesList components to use react-aria GridList for improved performance and simplify rule loading logic. Removed load more functionality and adjusted item rendering in RulesListItem for better structure and readability.

To be merged after the freeze is lifted.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5804 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/27/2025 **Status:** ✅ Merged **Merged:** 10/5/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/mobile-rules-gridlist` --- ### 📝 Commits (8) - [`908b3e3`](https://github.com/actualbudget/actual/commit/908b3e3591bff97157bdbbe01c04660d0dc5cff1) Refactor MobileRulesPage and RulesList components to use react-aria GridList for improved performance and simplify rule loading logic. Removed load more functionality and adjusted item rendering in RulesListItem for better structure and readability. - [`26d8812`](https://github.com/actualbudget/actual/commit/26d881246d266231a5849a671e1e14af32cee1f3) Refactor RulesList and RulesListItem components to remove unused Trans import from react-i18next, streamlining the codebase. - [`17b2db2`](https://github.com/actualbudget/actual/commit/17b2db2979a653b3584b667bbf7aeb27f7ac3180) Update MobileRulesPage to use 'listitem' role instead of 'button' for improved accessibility in rule retrieval methods. - [`a9e30c5`](https://github.com/actualbudget/actual/commit/a9e30c5899d42808f78f70231ca8554221a7570a) Refactor MobileRulesPage to enhance rule retrieval methods by using a more specific locator for visible rules, improving accuracy and maintainability. - [`6cf3b70`](https://github.com/actualbudget/actual/commit/6cf3b70ec8f9a8504546ef04c55ba288f17aa660) Update MobileRulesPage to refine rule filtering by removing 'DEFAULT' from the locator, enhancing the specificity of visible rules. - [`747aa7f`](https://github.com/actualbudget/actual/commit/747aa7f9ea6da93bd30440073f31ec1b28b388c2) Refactor MobileRulesPage to enhance rule retrieval by using 'grid' and 'row' roles for improved accessibility and specificity in rule filtering. - [`70bc91e`](https://github.com/actualbudget/actual/commit/70bc91e1f04fc068aa230c558020a0ed3439b70a) Update MobileRulesPage and RulesListItem to improve rule stage retrieval by using a specific test ID for the stage badge, enhancing code clarity and maintainability. - [`6c8e0ff`](https://github.com/actualbudget/actual/commit/6c8e0ff59789b79131d9e225e3bae3a9a84053d2) Refactor mobile rules list item and page model ### 📊 Changes **5 files changed** (+166 additions, -198 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/mobile-rules-page.ts` (+3 -6) 📝 `packages/desktop-client/src/components/mobile/rules/MobileRulesPage.tsx` (+3 -17) 📝 `packages/desktop-client/src/components/mobile/rules/RulesList.tsx` (+18 -29) 📝 `packages/desktop-client/src/components/mobile/rules/RulesListItem.tsx` (+136 -146) ➕ `upcoming-release-notes/5804.md` (+6 -0) </details> ### 📄 Description Refactor MobileRulesPage and RulesList components to use react-aria GridList for improved performance and simplify rule loading logic. Removed load more functionality and adjusted item rendering in RulesListItem for better structure and readability. To be merged **after** the freeze is lifted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:24:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?