github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5714] [MERGED] remove BANKS_WITH_LIMITED_HISTORY override array for GoCardless #6079

New Issue
Closed
opened 2026-02-28 21:23:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:23:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5714
Author: @matt-fidd
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @matt-fidd

Base: master ← Head: remove-limited-history

📝 Commits (4)

  • 0886f5f remove banks with limited history gocardless array
  • cba7598 note
  • 2b8f045 [autofix.ci] apply automated fixes
  • 2c583ac set 89 in fallback

📊 Changes

3 files changed (+13 additions, -78 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/bank-factory.js (+0 -71)
📝 packages/sync-server/src/app-gocardless/services/gocardless-service.js (+7 -7)
➕ upcoming-release-notes/5714.md (+6 -0)

📄 Description

This array is a bit of a crutch for the data we get from GoCardless, they don't always provide the right numbers for max_historical_days and transaction_total_days.

We fixed max_historical_days and removed the overrides by using a fallback default, this just does the same for transaction_total_days.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5714 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `remove-limited-history` --- ### 📝 Commits (4) - [`0886f5f`](https://github.com/actualbudget/actual/commit/0886f5f927db9b6e55cff620bdcd40f04846ece5) remove banks with limited history gocardless array - [`cba7598`](https://github.com/actualbudget/actual/commit/cba7598c9fe915f565cf910a212c36933363d81d) note - [`2b8f045`](https://github.com/actualbudget/actual/commit/2b8f045f222b2440816b7a3140b45a12104f511a) [autofix.ci] apply automated fixes - [`2c583ac`](https://github.com/actualbudget/actual/commit/2c583acf416d8f98c80d65081f2a2f0f2642338b) set 89 in fallback ### 📊 Changes **3 files changed** (+13 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/bank-factory.js` (+0 -71) 📝 `packages/sync-server/src/app-gocardless/services/gocardless-service.js` (+7 -7) ➕ `upcoming-release-notes/5714.md` (+6 -0) </details> ### 📄 Description This array is a bit of a crutch for the data we get from GoCardless, they don't always provide the right numbers for `max_historical_days` and `transaction_total_days`. We fixed `max_historical_days` and removed the overrides by using a fallback default, this just does the same for `transaction_total_days`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:23:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?