github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[Bug]: clicking "back" in rules modal crashes the page #606

New Issue
Closed
opened 2026-02-28 19:11:12 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-02-28 19:11:12 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Aug 31, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

Reproduction:

  1. to go payees page
  2. click "view associated rule" for one of the payees (if no payees have rules - create a rule for a payee)
  3. modal window opens
  4. click browser "back" button
  5. page crashes

What error did you receive?

No response

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Aug 31, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? Reproduction: 1. to go payees page 2. click "view associated rule" for one of the payees (if no payees have rules - create a rule for a payee) 3. modal window opens 4. click browser "back" button 5. page crashes ### What error did you receive? _No response_ ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the user interfacegood first issuebug labels 2026-02-28 19:11:12 -06:00
GiteaMirror commented 2026-02-28 19:11:12 -06:00
Author
Owner
Copy Link

@CampaniaGuy commented on GitHub (Mar 12, 2024):

Hi, on web i tried reproducing the issue but got no crash. Is this issue still occurring?

@CampaniaGuy commented on GitHub (Mar 12, 2024): Hi, on web i tried reproducing the issue but got no crash. Is this issue still occurring?
GiteaMirror commented 2026-02-28 19:11:13 -06:00
Author
Owner
Copy Link

@JukeboxRhino commented on GitHub (Jul 11, 2024):

I'm also unable to reproduce this

@JukeboxRhino commented on GitHub (Jul 11, 2024): I'm also unable to reproduce this
GiteaMirror commented 2026-02-28 19:11:13 -06:00
Author
Owner
Copy Link

@JahJoey commented on GitHub (Oct 24, 2024):

Was able to reproduce the issue.

Error logged in console:

ManageRulesModal.tsx:19 Uncaught Error: Possibly invalid use of ManageRulesModal, add the current url `/bootstrap` to the allowlist if you’re confident the modal can never appear on top of the `/rules` page.
    at ManageRulesModal (ManageRulesModal.tsx:19:13)
    at renderWithHooks (chunk-NBVTXK7E.js?v=3781d8be:12151:26)
    at updateFunctionComponent (chunk-NBVTXK7E.js?v=3781d8be:14557:28)
    at beginWork (chunk-NBVTXK7E.js?v=3781d8be:15892:22)
    at HTMLUnknownElement.callCallback2 (chunk-NBVTXK7E.js?v=3781d8be:3674:22)
    at Object.invokeGuardedCallbackDev (chunk-NBVTXK7E.js?v=3781d8be:3699:24)
    at invokeGuardedCallback (chunk-NBVTXK7E.js?v=3781d8be:3733:39)
    at beginWork$1 (chunk-NBVTXK7E.js?v=3781d8be:19733:15)
    at performUnitOfWork (chunk-NBVTXK7E.js?v=3781d8be:19166:20)
    at workLoopSync (chunk-NBVTXK7E.js?v=3781d8be:19105:13)

image

Seems as though using the back button causes it to think it's going to path /bootstrap instead of whatever page the user navigated from prior to /payees

@JahJoey commented on GitHub (Oct 24, 2024): Was able to reproduce the issue. Error logged in console: ``` ManageRulesModal.tsx:19 Uncaught Error: Possibly invalid use of ManageRulesModal, add the current url `/bootstrap` to the allowlist if you’re confident the modal can never appear on top of the `/rules` page. at ManageRulesModal (ManageRulesModal.tsx:19:13) at renderWithHooks (chunk-NBVTXK7E.js?v=3781d8be:12151:26) at updateFunctionComponent (chunk-NBVTXK7E.js?v=3781d8be:14557:28) at beginWork (chunk-NBVTXK7E.js?v=3781d8be:15892:22) at HTMLUnknownElement.callCallback2 (chunk-NBVTXK7E.js?v=3781d8be:3674:22) at Object.invokeGuardedCallbackDev (chunk-NBVTXK7E.js?v=3781d8be:3699:24) at invokeGuardedCallback (chunk-NBVTXK7E.js?v=3781d8be:3733:39) at beginWork$1 (chunk-NBVTXK7E.js?v=3781d8be:19733:15) at performUnitOfWork (chunk-NBVTXK7E.js?v=3781d8be:19166:20) at workLoopSync (chunk-NBVTXK7E.js?v=3781d8be:19105:13) ``` ![image](https://github.com/user-attachments/assets/14bf203b-a408-4506-980d-5b0ca4d3f00f) Seems as though using the back button causes it to think it's going to path `/bootstrap` instead of whatever page the user navigated from prior to `/payees`
GiteaMirror commented 2026-02-28 19:11:13 -06:00
Author
Owner
Copy Link

@tostasmistas commented on GitHub (Mar 11, 2025):

@MatissJanis @joel-jeremy

I was also faced with this issue in my local development environment, and it left me wondering, do we still need this check? - https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/modals/ManageRulesModal.tsx#L21-L27

I don't have enough context on why that error is thrown there, but do you think we could have it be a warning instead?

@tostasmistas commented on GitHub (Mar 11, 2025): @MatissJanis @joel-jeremy I was also faced with this issue in my local development environment, and it left me wondering, do we still need this check? - https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/modals/ManageRulesModal.tsx#L21-L27 I don't have enough context on why that error is thrown there, but do you think we could have it be a warning instead?
GiteaMirror commented 2026-02-28 19:11:14 -06:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Feb 13, 2026):

This looks to be fixed now, or at least, I can't replicate it anymore.

@matt-fidd commented on GitHub (Feb 13, 2026): This looks to be fixed now, or at least, I can't replicate it anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?