github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5671] [CLOSED] Fixes schedules date picker popup closing when clicking outside underlying popup #6059

New Issue
Closed
opened 2026-02-28 21:23:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:23:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5671
Author: @astro-msk
Created: 9/3/2025
Status: ❌ Closed

Base: master ← Head: fix-5638-schedules-date-picker-popup

📝 Commits (8)

  • a207895 added release notes
  • ef9df8b added onMouseDown to prevent opening onBlur and set shouldCloseOnInteractOutside to false by default
  • f036e9f Rename 5662.md to 5671.md
  • c7fcc10 reverted changes made to Popover component and added custom handler for the underlying popup
  • 80bf1e0 Merge branch 'master' into fix-5638-schedules-date-picker-popup
  • 92decad Merge branch 'master' into fix-5638-schedules-date-picker-popup
  • 9741509 modified code accd. to coderabbit review
  • 6cbca3b [autofix.ci] apply automated fixes

📊 Changes

2 files changed (+25 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx (+19 -0)
➕ upcoming-release-notes/5671.md (+6 -0)

📄 Description

Fixes #5638

  • The date picker popup used to close when clicking slightly outside the underlying popup, I fixed this by changing the shouldCloseOnInteractOutside default value to false.
  • I also added onMouseDown event handler to open the datepicker when clicked on Input element.

TODO: This solves the issue but now only selecting a date will close the datepicker, need to implement the functionality that clicking outside of the datepicker to close it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5671 **Author:** [@astro-msk](https://github.com/astro-msk) **Created:** 9/3/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-5638-schedules-date-picker-popup` --- ### 📝 Commits (8) - [`a207895`](https://github.com/actualbudget/actual/commit/a207895e5cc8ae4759c5e2415b35f5520e028033) added release notes - [`ef9df8b`](https://github.com/actualbudget/actual/commit/ef9df8bbb6759d249641949845cde8f66d1a114d) added onMouseDown to prevent opening onBlur and set shouldCloseOnInteractOutside to false by default - [`f036e9f`](https://github.com/actualbudget/actual/commit/f036e9fcbaa22c6f5bf25903afcaeb3a884101db) Rename 5662.md to 5671.md - [`c7fcc10`](https://github.com/actualbudget/actual/commit/c7fcc109fbf89c1fd1d4ef54ca6a719e52dff719) reverted changes made to Popover component and added custom handler for the underlying popup - [`80bf1e0`](https://github.com/actualbudget/actual/commit/80bf1e03dd837a79d45983ff5c76307c5b57c1d0) Merge branch 'master' into fix-5638-schedules-date-picker-popup - [`92decad`](https://github.com/actualbudget/actual/commit/92decad575713b9739d93fc65c5e42bb6583fb92) Merge branch 'master' into fix-5638-schedules-date-picker-popup - [`9741509`](https://github.com/actualbudget/actual/commit/9741509163ebdeeb1540ac3102ad72402a368cef) modified code accd. to coderabbit review - [`6cbca3b`](https://github.com/actualbudget/actual/commit/6cbca3bd7a3b8ad18ef8d927e78dd39b3aff5f2e) [autofix.ci] apply automated fixes ### 📊 Changes **2 files changed** (+25 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx` (+19 -0) ➕ `upcoming-release-notes/5671.md` (+6 -0) </details> ### 📄 Description Fixes #5638 - The date picker popup used to close when clicking slightly outside the underlying popup, I fixed this by changing the shouldCloseOnInteractOutside default value to false. - I also added onMouseDown event handler to open the datepicker when clicked on `Input` element. TODO: This solves the issue but now only selecting a date will close the datepicker, need to implement the functionality that clicking outside of the datepicker to close it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:23:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6059
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?