github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 04:49:45 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6557] [CLOSED] [WIP] Oxlint consistent type imports #60253

New Issue
Closed
opened 2026-05-07 02:15:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-07 02:15:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6557
Author: @miski-h
Created: 1/5/2026
Status: ❌ Closed

Base: master ← Head: oxlint-consistent-type-imports

📝 Commits (2)

  • 1c9d416 chore(oxlint): enforce consistent type imports
  • d1aacbb test: switch type import form to verify oxlint enforcement

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 .oxlintrc.json (+1 -1)
📝 packages/component-library/src/AlignedText.tsx (+1 -1)

📄 Description

The rule is already configured in oxlint with a defined preference.
This change promotes it from warning to error so it is enforced in CI.

No autofixes or code changes included.
Happy to close if this is premature due to existing violations.

As discussed in https://github.com/actualbudget/actual/issues/6548.

Summary by CodeRabbit

  • Chores
    • Enforced stricter TypeScript import consistency by raising the check to error-level.
    • Converted some imports to type-only form; no runtime or behavioral changes visible to users.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6557 **Author:** [@miski-h](https://github.com/miski-h) **Created:** 1/5/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `oxlint-consistent-type-imports` --- ### 📝 Commits (2) - [`1c9d416`](https://github.com/actualbudget/actual/commit/1c9d416589c3590ee1b8e16fc4bd18e84f8b26ea) chore(oxlint): enforce consistent type imports - [`d1aacbb`](https://github.com/actualbudget/actual/commit/d1aacbb388b3bc87b3ae81d420ab4a1a9d1b1abd) test: switch type import form to verify oxlint enforcement ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+1 -1) 📝 `packages/component-library/src/AlignedText.tsx` (+1 -1) </details> ### 📄 Description The rule is already configured in oxlint with a defined preference. This change promotes it from warning to error so it is enforced in CI. No autofixes or code changes included. Happy to close if this is premature due to existing violations. As discussed in https://github.com/actualbudget/actual/issues/6548. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enforced stricter TypeScript import consistency by raising the check to error-level. * Converted some imports to type-only form; no runtime or behavioral changes visible to users. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-07 02:15:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#60253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?