github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6552] [MERGED] Fix/saved filters position #60250

New Issue
Closed
opened 2026-05-07 02:15:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-07 02:15:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6552
Author: @FictionFics
Created: 1/5/2026
Status: ✅ Merged
Merged: 1/7/2026
Merged by: @MatissJanis

Base: master ← Head: fix/saved-filters-position

📝 Commits (7)

  • 214cc63 fix: move saved filters to end of dropdown with separator
  • 29b4b63 docs: add release notes
  • 983b1db [autofix.ci] apply automated fixes
  • 0b76f7a fixing typos
  • 7ef35a1 fix: use Menu.line for proper separator rendering
  • 26f9d88 refactor: remove duplication by extracting saved filter from array
  • 40d7407 [autofix.ci] apply automated fixes

📊 Changes

2 files changed (+22 additions, -8 deletions)

View changed files

📝 packages/desktop-client/src/components/filters/FiltersMenu.tsx (+16 -8)
➕ upcoming-release-notes/6552.md (+6 -0)

📄 Description

Summary

Fixes #6535

This PR moves the "saved filters" option to the end of the filters dropdown menu and adds a separator to distinguish it from regular filter options.

Changes

  • Reorganized filter menu items to place 'saved filters' at the end
  • Added separator before 'saved filters' to distinguish from regular filters
  • Maintained alphabetical sorting for regular filter options

Implementation Details

The solution uses a custom sort function in the Menu component that:

  1. Places 'saved' field at the end of the list
  2. Keeps regular filters alphabetically sorted
  3. Adds a separator item between regular and saved filters

Testing

  • Local testing: Unable to test due to environment setup issues
  • Will test on Netlify preview deployment once available
  • Expected behavior:
    • "Saved filters" appears at the end of dropdown
    • Visual separator before "Saved filters"
    • Other filters remain alphabetically sorted
    • All filter functionality works correctly

Screenshots

Screenshot 2026-01-05 at 09 36 41

Summary by CodeRabbit

  • Bug Fixes

    • Moved saved filters to the end of the filter dropdown and added a non-interactive divider to separate them.
    • Preserved alphabetical sorting within each group so items remain ordered.
    • Saved filters remain selectable after the divider.

  • Documentation

    • Added a release-note entry documenting this bug fix.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6552 **Author:** [@FictionFics](https://github.com/FictionFics) **Created:** 1/5/2026 **Status:** ✅ Merged **Merged:** 1/7/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix/saved-filters-position` --- ### 📝 Commits (7) - [`214cc63`](https://github.com/actualbudget/actual/commit/214cc630da62444c68c1bd1f738c8def63778144) fix: move saved filters to end of dropdown with separator - [`29b4b63`](https://github.com/actualbudget/actual/commit/29b4b63633e19d328d7535d64efce7f5bbc9bd38) docs: add release notes - [`983b1db`](https://github.com/actualbudget/actual/commit/983b1db5da586d4b6ff3eb34f9490ae754c54b52) [autofix.ci] apply automated fixes - [`0b76f7a`](https://github.com/actualbudget/actual/commit/0b76f7a6a634010b6580e5b10938348c8c4e29e9) fixing typos - [`7ef35a1`](https://github.com/actualbudget/actual/commit/7ef35a16d5dd64cb685ef1e10bf12e9afafdb0cf) fix: use Menu.line for proper separator rendering - [`26f9d88`](https://github.com/actualbudget/actual/commit/26f9d889401dc6359f253a986ec5439827f55694) refactor: remove duplication by extracting saved filter from array - [`40d7407`](https://github.com/actualbudget/actual/commit/40d74070b6c260ad7fd144b9ab025da8cc1fb697) [autofix.ci] apply automated fixes ### 📊 Changes **2 files changed** (+22 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/filters/FiltersMenu.tsx` (+16 -8) ➕ `upcoming-release-notes/6552.md` (+6 -0) </details> ### 📄 Description ## Summary Fixes #6535 This PR moves the "saved filters" option to the end of the filters dropdown menu and adds a separator to distinguish it from regular filter options. ## Changes - Reorganized filter menu items to place 'saved filters' at the end - Added separator before 'saved filters' to distinguish from regular filters - Maintained alphabetical sorting for regular filter options ## Implementation Details The solution uses a custom sort function in the Menu component that: 1. Places 'saved' field at the end of the list 2. Keeps regular filters alphabetically sorted 3. Adds a separator item between regular and saved filters ## Testing - [x] Local testing: Unable to test due to environment setup issues - [x] Will test on Netlify preview deployment once available - [x] Expected behavior: - "Saved filters" appears at the end of dropdown - Visual separator before "Saved filters" - Other filters remain alphabetically sorted - All filter functionality works correctly ## Screenshots <img width="105" height="409" alt="Screenshot 2026-01-05 at 09 36 41" src="https://github.com/user-attachments/assets/5ae7c752-8835-46a1-8cde-524a266a9676" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Moved saved filters to the end of the filter dropdown and added a non-interactive divider to separate them. * Preserved alphabetical sorting within each group so items remain ordered. * Saved filters remain selectable after the divider. * **Documentation** * Added a release-note entry documenting this bug fix. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-07 02:15:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#60250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?