github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5556] [MERGED] feat(mobile): ability to delete rules #5995

New Issue
Closed
opened 2026-02-28 21:22:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:22:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5556
Author: @MatissJanis
Created: 8/14/2025
Status: ✅ Merged
Merged: 8/16/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/rules-delete

📝 Commits (7)

  • a89a5c2 feat(mobile): ability to delete rules
  • 50c458b Add release notes for PR #5556
  • cddabea Update VRT
  • a630b47 Enhance rule deletion process with error handling and translation support
  • d469d6e Merge branch 'matiss/rules-delete' of github.com:actualbudget/actual into matiss/rules-delete
  • 5a1121f Update VRT
  • 63f6b46 Merge branch 'master' into matiss/rules-delete

📊 Changes

11 files changed (+107 additions, -24 deletions)

View changed files

📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/Modals.tsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/rules/MobileRuleEditPage.tsx (+47 -0)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+10 -2)
📝 packages/desktop-client/src/components/modals/ConfirmDeleteModal.tsx (+6 -6)
📝 packages/desktop-client/src/components/rules/RuleEditor.tsx (+23 -8)
📝 packages/desktop-client/src/hooks/useTransactionBatchActions.ts (+9 -3)
📝 packages/desktop-client/src/modals/modalsSlice.ts (+2 -2)
➕ upcoming-release-notes/5556.md (+7 -0)

📄 Description

Mobile rule deletion button

Also renamed confirm-transaction-delete to confirm-delete so it is more generic and re-usable for other things.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5556 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/14/2025 **Status:** ✅ Merged **Merged:** 8/16/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/rules-delete` --- ### 📝 Commits (7) - [`a89a5c2`](https://github.com/actualbudget/actual/commit/a89a5c212d8d8a78379c104ce6642cefe880acff) feat(mobile): ability to delete rules - [`50c458b`](https://github.com/actualbudget/actual/commit/50c458bbb4100082884e1a3e653b216da15655df) Add release notes for PR #5556 - [`cddabea`](https://github.com/actualbudget/actual/commit/cddabead8bac740ca523d8b83146d0e0aa46e0e0) Update VRT - [`a630b47`](https://github.com/actualbudget/actual/commit/a630b4724264bffaf69a53364a8fa37d20e1a461) Enhance rule deletion process with error handling and translation support - [`d469d6e`](https://github.com/actualbudget/actual/commit/d469d6ef609625a12d65cb2840f07e29bf4acebc) Merge branch 'matiss/rules-delete' of github.com:actualbudget/actual into matiss/rules-delete - [`5a1121f`](https://github.com/actualbudget/actual/commit/5a1121f9dd6c99309a03f8b86412bcba94a3795d) Update VRT - [`63f6b46`](https://github.com/actualbudget/actual/commit/63f6b46c138a1dba6bd2b20f3e5ac80027afd6f3) Merge branch 'master' into matiss/rules-delete ### 📊 Changes **11 files changed** (+107 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/rules.mobile.test.ts-snapshots/Mobile-Rules-clicking-on-a-rule-opens-edit-form-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/Modals.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/rules/MobileRuleEditPage.tsx` (+47 -0) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+10 -2) 📝 `packages/desktop-client/src/components/modals/ConfirmDeleteModal.tsx` (+6 -6) 📝 `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+23 -8) 📝 `packages/desktop-client/src/hooks/useTransactionBatchActions.ts` (+9 -3) 📝 `packages/desktop-client/src/modals/modalsSlice.ts` (+2 -2) ➕ `upcoming-release-notes/5556.md` (+7 -0) </details> ### 📄 Description Mobile rule deletion button Also renamed `confirm-transaction-delete` to `confirm-delete` so it is more generic and re-usable for other things. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:22:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?