github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5518] [MERGED] Extracted rule editor outside of the modal and into its own component #5976

New Issue
Closed
opened 2026-02-28 21:21:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:21:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5518
Author: @MatissJanis
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/7/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/move-rule-editor

📝 Commits (2)

  • b1fa144 Extracted rule editor outside of the modal and into its own component
  • 1f06f00 Add release notes

📊 Changes

7 files changed (+1405 additions, -1291 deletions)

View changed files

📝 packages/desktop-client/src/components/filters/AppliedFilters.tsx (+1 -1)
📝 packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/EditRuleModal.jsx (+8 -1284)
📝 packages/desktop-client/src/components/reports/reports/Summary.tsx (+1 -1)
➕ packages/desktop-client/src/components/rules/RuleEditor.tsx (+1383 -0)
📝 packages/desktop-client/src/components/schedules/ScheduleDetails.tsx (+4 -3)
➕ upcoming-release-notes/5518.md (+6 -0)

📄 Description

Split off from https://github.com/actualbudget/actual/pull/5516

No functional changes here. Only moving the rule editor logic outside of the modal so it could be used in a stand-alone page for mobile. Added a few types too to satisfy typescript. But did zero actual logic modifications to keep this PR as simple to review as possible.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5518 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/move-rule-editor` --- ### 📝 Commits (2) - [`b1fa144`](https://github.com/actualbudget/actual/commit/b1fa1445600fa65e1a7606df793bbcd9a492e366) Extracted rule editor outside of the modal and into its own component - [`1f06f00`](https://github.com/actualbudget/actual/commit/1f06f0048d1a42c120f5887f6546b6e354e99f48) Add release notes ### 📊 Changes **7 files changed** (+1405 additions, -1291 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/filters/AppliedFilters.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/EditRuleModal.jsx` (+8 -1284) 📝 `packages/desktop-client/src/components/reports/reports/Summary.tsx` (+1 -1) ➕ `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+1383 -0) 📝 `packages/desktop-client/src/components/schedules/ScheduleDetails.tsx` (+4 -3) ➕ `upcoming-release-notes/5518.md` (+6 -0) </details> ### 📄 Description Split off from https://github.com/actualbudget/actual/pull/5516 No functional changes here. Only moving the rule editor logic outside of the modal so it could be used in a stand-alone page for mobile. Added a few types too to satisfy typescript. But did zero actual logic modifications to keep this PR as simple to review as possible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:21:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5976
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?