github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 12:59:01 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #4912] [MERGED] Allow-return-to-trigger-default-actions #59311

New Issue
Closed
opened 2026-05-07 00:36:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-07 00:36:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4912
Author: @SamBobBarnes
Created: 5/2/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @joel-jeremy

Base: master ← Head: Allow-return-to-trigger-default-actions

📝 Commits (10+)

📊 Changes

9 files changed (+206 additions, -18 deletions)

View changed files

📝 packages/component-library/package.json (+5 -2)
📝 packages/component-library/src/InitialFocus.ts (+32 -7)
➕ packages/component-library/src/InitialFocus.web.test.tsx (+117 -0)
➕ packages/component-library/vitest.web.config.ts (+35 -0)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+4 -4)
📝 packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx (+3 -2)
📝 packages/desktop-client/src/components/sidebar/Account.tsx (+3 -3)
➕ upcoming-release-notes/4912.md (+6 -0)
📝 yarn.lock (+1 -0)

📄 Description

This change should fix The InitialFocus component so that buttons and inputs correctly focus by default.

This will resolve any issues where one would expect the return key to execute the default action and will continue to focus text inputs correctly as well as enabling a new feature to optionally have the focused text input have the text selected by default.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4912 **Author:** [@SamBobBarnes](https://github.com/SamBobBarnes) **Created:** 5/2/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `Allow-return-to-trigger-default-actions` --- ### 📝 Commits (10+) - [`e53a694`](https://github.com/actualbudget/actual/commit/e53a694daf8013f3fa84daa617485d7901ded206) button being focused - [`6ed68b9`](https://github.com/actualbudget/actual/commit/6ed68b92c74db200354cbaef62c36626c0db0078) working - [`eb97ae7`](https://github.com/actualbudget/actual/commit/eb97ae742765ff84c597d0d6d972190d57d2ff23) tests - [`4c0b1b0`](https://github.com/actualbudget/actual/commit/4c0b1b02d42536ac3434a995d2bec930d5f48ce4) text selection test - [`1ad7513`](https://github.com/actualbudget/actual/commit/1ad7513f291ed9da65ac5ceb48ac356a8b4f1fc6) allow for ref injection - [`7d0e0a9`](https://github.com/actualbudget/actual/commit/7d0e0a91607c8c5ca1548eea47abb93e88115693) updated some of the usages - [`d171081`](https://github.com/actualbudget/actual/commit/d171081e8fd44c6317dd4032bb98549c163d2705) release notes - [`2a0d061`](https://github.com/actualbudget/actual/commit/2a0d061446cfaae2ccb2fb4de45a4bb34913b683) rename of prop - [`49a555b`](https://github.com/actualbudget/actual/commit/49a555ba2979040f74daec08ffa7bd9e8a04c328) docs - [`2331681`](https://github.com/actualbudget/actual/commit/233168163854efbe6fc51b62e3748f86b8a279d8) fixed release note ### 📊 Changes **9 files changed** (+206 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/package.json` (+5 -2) 📝 `packages/component-library/src/InitialFocus.ts` (+32 -7) ➕ `packages/component-library/src/InitialFocus.web.test.tsx` (+117 -0) ➕ `packages/component-library/vitest.web.config.ts` (+35 -0) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/budget/envelope/CoverMenu.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/sidebar/Account.tsx` (+3 -3) ➕ `upcoming-release-notes/4912.md` (+6 -0) 📝 `yarn.lock` (+1 -0) </details> ### 📄 Description This change should fix The InitialFocus component so that buttons and inputs correctly focus by default. This will resolve any issues where one would expect the return key to execute the default action and will continue to focus text inputs correctly as well as enabling a new feature to optionally have the focused text input have the text selected by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-07 00:36:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#59311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?