github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5431] [CLOSED] [WIP] Disallow the updating of transactions in a closed account which changes its balance #5931

New Issue
Closed
opened 2026-02-28 21:21:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:21:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5431
Author: @Serializator
Created: 7/31/2025
Status: ❌ Closed

Base: master ← Head: disallow-balance-changes-closed-account-5413

📝 Commits (3)

  • b691666 disallow creating, updating the amount or deleting transactions on a closed account in the API
  • 71a91a7 close account only after balance is transferred
  • 940f0d4 [autofix.ci] apply automated fixes

📊 Changes

2 files changed (+33 additions, -9 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/app.ts (+2 -2)
📝 packages/loot-core/src/server/transactions/index.ts (+31 -7)

📄 Description

This PR disallows the updating of transactions in closed accounts in ways it would affect its balance.

The changes are two-part. There is the enforcement on the API level to ensure this can't happen. Then there is the UI / UX to prevent the end-user from updating "attributes" of a transaction which may affect the balance of the account.

Currently I'm working under the assumption the primary ways this may happen is by updating the amount of a transaction or even updating the account which a transaction belongs to.

Fixes #5413

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5431 **Author:** [@Serializator](https://github.com/Serializator) **Created:** 7/31/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `disallow-balance-changes-closed-account-5413` --- ### 📝 Commits (3) - [`b691666`](https://github.com/actualbudget/actual/commit/b691666a7d371879e66e39f56eb2d3a784738238) disallow creating, updating the amount or deleting transactions on a closed account in the API - [`71a91a7`](https://github.com/actualbudget/actual/commit/71a91a758c7796beed73eb2767bbdf8135fb2c8b) close account only after balance is transferred - [`940f0d4`](https://github.com/actualbudget/actual/commit/940f0d45c00c82a12407822f451c5e85e70cea17) [autofix.ci] apply automated fixes ### 📊 Changes **2 files changed** (+33 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/app.ts` (+2 -2) 📝 `packages/loot-core/src/server/transactions/index.ts` (+31 -7) </details> ### 📄 Description This PR disallows the updating of transactions in closed accounts in ways it would affect its balance. The changes are two-part. There is the enforcement on the API level to ensure this can't happen. Then there is the UI / UX to prevent the end-user from updating "attributes" of a transaction which may affect the balance of the account. Currently I'm working under the assumption the primary ways this may happen is by updating the amount of a transaction or even updating the account which a transaction belongs to. --- Fixes #5413 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:21:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?