github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5415] [MERGED] Fix transaction hooks and improve transactions loading experience in mobile #5922

New Issue
Closed
opened 2026-02-28 21:20:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5415
Author: @joel-jeremy
Created: 7/28/2025
Status: ✅ Merged
Merged: 8/12/2025
Merged by: @joel-jeremy

Base: master ← Head: fix-useTransactions-and-improve-loading-experience

📝 Commits (7)

  • b37c679 Fix transaction hooks and improve transactions loading experience in mobile
  • ea3c866 Allow skipping of running balance calculation on preview transactions + recalculate running balances if there are any inversed transaction amounts
  • da66e03 [autofix.ci] apply automated fixes
  • 421f871 Disable PullToRefresh when transaction list is in loading state (See #5080)
  • ba2747d Cleanup
  • 697fa76 Add calculateRunningBalancesTopDown to calculate top down from starting balance
  • bb548a7 update balance sheet value

📊 Changes

10 files changed (+303 additions, -317 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (+6 -5)
📝 packages/desktop-client/src/components/mobile/budget/CategoryTransactions.tsx (+9 -8)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (+23 -19)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (+49 -13)
📝 packages/desktop-client/src/hooks/useCategoryPreviewTransactions.ts (+5 -8)
📝 packages/desktop-client/src/hooks/usePreviewTransactions.ts (+22 -257)
📝 packages/desktop-client/src/hooks/useTransactions.ts (+181 -5)
➕ upcoming-release-notes/5415.md (+6 -0)

📄 Description

Fix reverted changes on some hooks (could be due to incorrect rebase/merge), this PR aims to fix that + a change on the loading experience on mobile to display transactions as they load.

Meaning, normal transactions would be displayed even when the preview transactions are not yet loaded, and display the preview transactions as they load (a loading indicator would be displayed to indicate the preview transactions are still being loaded). This should improve the user experience because the preview transactions are slower to load than the normal transactions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5415 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 8/12/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `fix-useTransactions-and-improve-loading-experience` --- ### 📝 Commits (7) - [`b37c679`](https://github.com/actualbudget/actual/commit/b37c6794998e23a5375cfb8101b8bce97b9606a2) Fix transaction hooks and improve transactions loading experience in mobile - [`ea3c866`](https://github.com/actualbudget/actual/commit/ea3c8661f132422210b745b1e02845bfe90b4273) Allow skipping of running balance calculation on preview transactions + recalculate running balances if there are any inversed transaction amounts - [`da66e03`](https://github.com/actualbudget/actual/commit/da66e036b14b78a146d82d66478b7c746f181b1d) [autofix.ci] apply automated fixes - [`421f871`](https://github.com/actualbudget/actual/commit/421f871d9f3b9257ec5b0a4842e7b197a862a02a) Disable PullToRefresh when transaction list is in loading state (See #5080) - [`ba2747d`](https://github.com/actualbudget/actual/commit/ba2747deadc5a2cdf33c9d9a62610066270a0ae0) Cleanup - [`697fa76`](https://github.com/actualbudget/actual/commit/697fa76b52d6b0db0b65b6c20e06d2893020da62) Add calculateRunningBalancesTopDown to calculate top down from starting balance - [`bb548a7`](https://github.com/actualbudget/actual/commit/bb548a742bbf71c637f9daa3b3e612af76c58052) update balance sheet value ### 📊 Changes **10 files changed** (+303 additions, -317 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/mobile/budget/CategoryTransactions.tsx` (+9 -8) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx` (+23 -19) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts` (+49 -13) 📝 `packages/desktop-client/src/hooks/useCategoryPreviewTransactions.ts` (+5 -8) 📝 `packages/desktop-client/src/hooks/usePreviewTransactions.ts` (+22 -257) 📝 `packages/desktop-client/src/hooks/useTransactions.ts` (+181 -5) ➕ `upcoming-release-notes/5415.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fix reverted changes on some hooks (could be due to incorrect rebase/merge), this PR aims to fix that + a change on the loading experience on mobile to display transactions as they load. Meaning, normal transactions would be displayed even when the preview transactions are not yet loaded, and display the preview transactions as they load (a loading indicator would be displayed to indicate the preview transactions are still being loaded). This should improve the user experience because the preview transactions are slower to load than the normal transactions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?