github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5404] [MERGED] Allow Docker image build by workflow dispatch on forks #5916

New Issue
Closed
opened 2026-02-28 21:20:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5404
Author: @Jackenmen
Created: 7/27/2025
Status: ✅ Merged
Merged: 8/4/2025
Merged by: @matt-fidd

Base: master ← Head: allow_docker_image_build_on_forks

📝 Commits (2)

  • 445ddc3 Allow Docker image build by workflow dispatch on forks
  • 885bab1 Add release note

📊 Changes

2 files changed (+11 additions, -5 deletions)

View changed files

📝 .github/workflows/docker-edge.yml (+5 -5)
➕ upcoming-release-notes/5404.md (+6 -0)

📄 Description

I can understand not wanting to auto-trigger Docker builds on forks on schedule or whenever a push to master or a pull request is made but I think there's no reason to limit the ability for the fork owner to trigger a build manually through a workflow dispatch. As long as we exclude the push to DockerHub (which, unlike GitHub Packages, requires credentials not auto-generated by GH Actions), it can work just fine.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5404 **Author:** [@Jackenmen](https://github.com/Jackenmen) **Created:** 7/27/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `allow_docker_image_build_on_forks` --- ### 📝 Commits (2) - [`445ddc3`](https://github.com/actualbudget/actual/commit/445ddc3c0e5027bcc9f1234406f47073ac9b4c63) Allow Docker image build by workflow dispatch on forks - [`885bab1`](https://github.com/actualbudget/actual/commit/885bab1a10131fb107239451586f49a64cd2c09a) Add release note ### 📊 Changes **2 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-edge.yml` (+5 -5) ➕ `upcoming-release-notes/5404.md` (+6 -0) </details> ### 📄 Description I can understand not wanting to auto-trigger Docker builds on forks on schedule or whenever a push to master or a pull request is made *but* I think there's no reason to limit the ability for the fork owner to trigger a build manually through a workflow dispatch. As long as we exclude the push to DockerHub (which, unlike GitHub Packages, requires credentials not auto-generated by GH Actions), it can work just fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5916
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?